Android ImageView from ListView

Question

I'm trying to pass KEY_THUMB_URL to SingleMenuItemActivity.class to show Image onclick listview. I have marked those area //Not Working . Please correct my codings, I'm pretty new to android.

CustomizedListView.class

    public class CustomizedListView extends Activity {
    // All static variables
    static final String URL = "http://api.androidhive.info/music/music.xml";
    // XML node keys
    static final String KEY_SONG = "song"; // parent node
    static final String KEY_ID = "id";
    static final String KEY_TITLE = "title";
    static final String KEY_ARTIST = "artist";
    static final String KEY_DURATION = "duration";
    static final String KEY_THUMB_URL = "thumb_url";

    ListView list;
    LazyAdapter adapter;

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);


        ArrayList<HashMap<String, String>> songsList = new ArrayList<HashMap<String, String>>();

        XMLParser parser = new XMLParser();
        String xml = parser.getXmlFromUrl(URL); // getting XML from URL
        Document doc = parser.getDomElement(xml); // getting DOM element

        NodeList nl = doc.getElementsByTagName(KEY_SONG);
        // looping through all song nodes <song>
        for (int i = 0; i < nl.getLength(); i++) {
            // creating new HashMap
            HashMap<String, String> map = new HashMap<String, String>();
            Element e = (Element) nl.item(i);
            // adding each child node to HashMap key => value
            map.put(KEY_ID, parser.getValue(e, KEY_ID));
            map.put(KEY_TITLE, parser.getValue(e, KEY_TITLE));
            map.put(KEY_ARTIST, parser.getValue(e, KEY_ARTIST));
            map.put(KEY_DURATION, parser.getValue(e, KEY_DURATION));
            map.put(KEY_THUMB_URL, parser.getValue(e, KEY_THUMB_URL));

            // adding HashList to ArrayList
            songsList.add(map);
        }


        list=(ListView)findViewById(R.id.list);

        // Getting adapter by passing xml data ArrayList
        adapter=new LazyAdapter(this, songsList);        
        list.setAdapter(adapter);


        // Click event for single list row
        list.setOnItemClickListener(new OnItemClickListener() {

            @Override
            public void onItemClick(AdapterView<?> parent, View view,
                    int position, long id) {


                String title = ((TextView) view.findViewById(R.id.title)).getText().toString();
                String description = ((TextView) view.findViewById(R.id.artist)).getText().toString();


                // Starting new intent
                Intent in = new Intent(getApplicationContext(), SingleMenuItemActivity.class);

                in.putExtra(KEY_TITLE, title);
                in.putExtra(KEY_THUMB_URL, R.id.list_image); //Modified as told by Nandeesh 
                in.putExtra(KEY_ARTIST, description);
                startActivity(in);  }


        });     
    }   
}

SingleMenuItemActivity.class

    public class SingleMenuItemActivity  extends Activity {


    static final String KEY_TITLE = "title";
    static final String KEY_ARTIST = "artist";  
    static final String KEY_THUMB_URL = "thumb_url";

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.single_list_item);

        Intent in = getIntent();

        String title = in.getStringExtra(KEY_TITLE);
        String description = in.getStringExtra(KEY_ARTIST);

       // int thumb_image = in.getIntExtra(KEY_THUMB_URL); // ERROR : The method getIntExtra(String, int) in the type Intent is not applicable for the arguments (String)

        TextView lblName = (TextView) findViewById(R.id.name_label);
        TextView lblDesc = (TextView) findViewById(R.id.description_label);

       // ImageView thumb = (ImageView) findViewById(R.id.imageView1); 

        lblName.setText(title);
       // thumb.setImageResource(thumb_image); //modified as told by Nandeesh                    
        lblDesc.setText(description);

    }
}

LazyAdapter.class

    public class LazyAdapter extends BaseAdapter {

    private Activity activity;
    private ArrayList<HashMap<String, String>> data;
    private static LayoutInflater inflater=null;
    public ImageLoader imageLoader; 

    public LazyAdapter(Activity a, ArrayList<HashMap<String, String>> d) {
        activity = a;
        data=d;
        inflater = (LayoutInflater)activity.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        imageLoader=new ImageLoader(activity.getApplicationContext());
    }

    public int getCount() {
        return data.size();
    }

    public Object getItem(int position) {
        return position;
    }

    public long getItemId(int position) {
        return position;
    }

    public View getView(int position, View convertView, ViewGroup parent) {
        View vi=convertView;
        if(convertView==null)
            vi = inflater.inflate(R.layout.list_row, null);

        TextView title = (TextView)vi.findViewById(R.id.title); // title
        TextView artist = (TextView)vi.findViewById(R.id.artist); // artist name
        TextView duration = (TextView)vi.findViewById(R.id.duration); // duration
        ImageView thumb_image=(ImageView)vi.findViewById(R.id.list_image); // thumb image

        HashMap<String, String> song = new HashMap<String, String>();
        song = data.get(position);

        // Setting all values in listview
        title.setText(song.get(CustomizedListView.KEY_TITLE));
        artist.setText(song.get(CustomizedListView.KEY_ARTIST));
        duration.setText(song.get(CustomizedListView.KEY_DURATION));
        imageLoader.DisplayImage(song.get(CustomizedListView.KEY_THUMB_URL), thumb_image);
        return vi;
    }
}

is it throwing exception? if so post the logcat. Explain what is not working — nandeesh, Aug 12 '12 at 08:10
there is no error, my Image is just not showing onclick. Please help Nandeesh. Thanks — KC Chai, Aug 12 '12 at 08:12
Not yet. But i'm still working on answers provided by Nandeesh and Yul. Will update you my progress . thanks Android Coder — KC Chai, Aug 13 '12 at 09:03

Trung Nguyen · Answer 1 · 2012-08-12T16:17:22.097

Because you don't add your LazyAdapter code so I try to guess and do this:

     list.setOnItemClickListener(new OnItemClickListener() {

                @Override
                public void onItemClick(AdapterView<?> parent, View view,
                        int position, long id) {


HashMap<String, String> map = yourAdapter.getItem(position); // create an Adapter in your `onCreate` . yourAdapter = new LazyAdapter(this, songsList); 
                    // Starting new intent
                    Intent in = new Intent(getApplicationContext(), SingleMenuItemActivity.class);
                        in.putExtra(KEY_TITLE, map.get(KEY_TITLE));
                        in.putExtra(KEY_THUMB_URL, map.get(KEY_THUMB_URL)); //make sure this is putExtra(String name, String value);
                        in.putExtra(KEY_ARTIST, map.get(KEY_ARTIST));
                        startActivity(in);  }


            });

Bonus: In CustomizedListView do this LazyAdapter adapter = new LazyAdapter(this, songsList);

so in setOnItemClickListener write HashMap<String, String> map = adapter.getItem(position); // get data of the clicked item. In LazyAdapter change your method getItem to

@Override
public Object getItem(int position) {
    // TODO Auto-generated method stub
    return data.get(position);
}

In your SingleMenuItemActivity.class get URL image from Intent Extra.Download it like you did in LazyAdapter and set to ImageView

Thanks Yul, I'll try your codes then I will update my results here. — KC Chai, Aug 12 '12 at 13:30
Yul, I tried to implement your codes, I think I got confused on adding the Lazy Adapter. Could you please show me how to do it. I just updated my codes with my LazyAdapter.class. Please check. Thanks — KC Chai, Aug 12 '12 at 14:24
My suggestion code is for click event in `CustomizedListView `. Simple explaination : When you click on an item in `ListView` get item's data. Extract fields you want to transfer to another activity. — Trung Nguyen, Aug 12 '12 at 16:09

score 0 · Accepted Answer · answered Aug 12 '12 at 08:22

0

In this line

in.putExtra(KEY_THUMB_URL, R.id.list_image);

R.id.list_image is not a drawable. Only R.drawable.[ ] can be used to setImageResource.

Then you should not use String thumb_image = in.getStringExtra(KEY_THUMB_URL) since putextra is adding a integer and you are trying to get a string

You should use

int thumb_image = in.getIntExtra(KEY_THUMB_URL)
thumb.setImageResource(thumb_image)

answered Aug 12 '12 at 08:22

nandeesh

24,740
6
69
79

int thumb_image = in.getIntExtra(KEY_THUMB_URL); shows error The method getIntExtra(String, int) in the type Intent is not applicable for the arguments (String) – KC Chai Aug 12 '12 at 08:47
I've made the necessary changes to my codes above, Nandeesh, please assist me with this. – KC Chai Aug 12 '12 at 08:48
Nandeesh please help. Thank you very much – KC Chai Aug 12 '12 at 09:08
use this int thumb_image = in.getIntExtra(KEY_THUMB_URL, -1); – nandeesh Aug 13 '12 at 18:03

Android ImageView from ListView

2 Answers2

Linked