22

These threads do NOT answer me:

resetting a stringstream

How do you clear a stringstream variable?

std::ifstream file( szFIleName_p );
if( !file ) return false;

// create a string stream for parsing

std::stringstream szBuffer;

std::string szLine;     // current line
std::string szKeyWord;  // first word on the line identifying what data it contains

while( !file.eof()){

    // read line by line

    std::getline(file, szLine);

    // ignore empty lines

    if(szLine == "") continue;

    szBuffer.str("");
    szBuffer.str(szLine);
    szBuffer>>szKeyWord;

szKeyword will always contain the first word, szBuffer is not being reset. I can't find a clear example anywhere on how to use stringstream.

New code after answer:

...
szBuffer.str(szLine);
szBuffer.clear();
szBuffer>>szKeyWord;
...

Ok, thats my final version:

std::string szLine;     // current line
std::string szKeyWord;  // first word on the line identifying what data it contains

// read line by line

while( std::getline(file, szLine) ){

    // ignore empty lines

    if(szLine == "") continue;

    // create a string stream for parsing

    std::istringstream szBuffer(szLine);
    szBuffer>>szKeyWord;
Remy Lebeau
  • 555,201
  • 31
  • 458
  • 770
Icebone1000
  • 1,231
  • 4
  • 13
  • 25
  • possible duplicate of [How to reuse an ostringstream?](http://stackoverflow.com/questions/624260/how-to-reuse-an-ostringstream) – maxschlepzig Apr 08 '14 at 07:39

6 Answers6

35

You didn't clear() the stream after calling str(""). Take another look at this answer, it also explains why you should reset using str(std::string()). And in your case, you could also reset the contents using only str(szLine).

If you don't call clear(), the flags of the stream (like eof) wont be reset, resulting in surprising behaviour ;)

Community
  • 1
  • 1
Marcus Riemer
  • 7,244
  • 8
  • 51
  • 76
  • dammit, I saw a thread saying clear just clears error flags..wtf man..can you explain me why I need both ? using just clear seems to work..? – Icebone1000 Aug 24 '12 at 15:29
  • 1
    These are related. If you don't call `clear()`, the stream will think its still in the `eof` state. – Marcus Riemer Aug 24 '12 at 15:30
  • So clear important task on reset is putting the seek pointer (whatever it is called) at the beginning again? In the end, thats what I need: szBuffer.str(szLine);szBuffer.clear(); – Icebone1000 Aug 24 '12 at 15:36
  • Its not about the seek pointer, its about the whole state of the stream. And yes, in your case you can simply "overwrite" the previous content like that. – Marcus Riemer Aug 24 '12 at 15:39
  • Any chance youd be able to explain how not calling clear make it outputs a string from the previous content? I mean, that monster is holding all the strings allways? – Icebone1000 Aug 24 '12 at 15:46
  • 3
    This doesn't actually work reliably. You also need to reset any formatting flags to the default. Including those you don't know about, because they were allocated by a call to `std::ios_base::xalloc()` behind your back. – James Kanze Aug 24 '12 at 15:49
10

It depends what you're doing with it. It's generally easier to just create a new istringstream or ostringstream. To "reset" a stream, you have to clear its buffer, clear any error flags, reset any formatting flags, plus the precision and fill, reimbue it with the original locale, and not forget any extended formatting information generated with a value returned from xalloc. In sum, impossible to get correct.

And while I'm at it, your loop is wrong, and will probably result in the last line being processed twice. file.eof() only has a usable meaning after the input has failed (and even then, it's not 100% reliable). What you want is:

std::string line;
while ( std::getline( file, line ) ) {
    if ( !line.empty() ) {
        std::istringstream buffer( line );
        //  ...
    }
}

(Actually, you probably want to trim trailing white space from the line before the test for empty.)

James Kanze
  • 150,581
  • 18
  • 184
  • 329
  • 5
    I love how there's a lot of resources out there explaining all those very obvious std information out there, in an organized and well documented way, not – Icebone1000 Aug 24 '12 at 15:55
  • 2
    I could swear there was a committee member in a video claiming people were getting bad performance with streams because they were using them incorrectly by recreating them in loops instead of reusing references to them. I feel my life is a lie. – arthropod Apr 16 '20 at 00:33
  • How about moving the buffer out of the old stringstream, then creating a fresh stringstream, using the old buffer? That way, you would reset everything, but reuse the storage. I tentatively think the methods added in C++20 allow this. – Tom Anderson Jul 06 '23 at 15:42
  • Having spent a few minutes playing, this seems to work: `std::stringstream ss; /* use ss */ std::string buffer = std::move(ss.rdbuf()->str()); buffer.resize(0); ss = std::stringstream(std::move(buffer));`? Not sure if this actually reuses the allocation, though! – Tom Anderson Jul 06 '23 at 16:04
3

ss is stringstream. Use

  • first step: ss.clear();
  • second step: ss.str("");

to reuse the stringstream -- completely clear the string stream.

1

In most cases, it is easier to create a new istringstream or ostringstream instead of resetting the same ones.

However, if you do want to resent them:

  • Resent flags of the stream (to avoid unexpected behavior) using clear ().

  • While you can correct the contents of your stringstream using str (""), for efficiency purposes we might prefer str(std::string()).

Madhav Datt
  • 1,065
  • 2
  • 10
  • 25
0

If you have the stream in a class member, use unique_ptr<stringstream>, then just reset(new stringstream(...)) to reuse it.

Петър Петров
  • 1,966
  • 1
  • 17
  • 14
0

Imagine a config file.

par1=11
par2=22

codes:

std::string line, strpar1, strpar2;
int par1, par2;
std::ifstream configfile("config.cfg");

std::getline(configfile, line);    // first line to variable "line"
std::istringstream sline(line);
while (std::getline(sline, strpar1, '='));
par1 = std::stoi(strpar1);  // par1 get 11

bool b = sline.eof(); // true

std::getline(configfile, line);    // second line to variable "line"
sline.clear();    //
sline.str(line);    // reuse "sline"

b = sline.good();  // true  // goodbit is zero, indicating that none of the other bits is set.
b = sine.fail();  // false
b = sline.bad();  // false
b = sline.eof(); // false

while (std::getline(sline, strpar2, '='));
par2 = std::stoi(strpar2);  // par2 get 22

goodbit is zero, indicating that none of the other bits is set

Nick Dong
  • 3,638
  • 8
  • 47
  • 84