Android finish() Activity Not working

Question

I got this error in my codes when i use finish(); "The method finish() is undefined for the type SaveImageTask" . Am I missing some declarations or anything. Can someone please guide me on this.

    public class SaveImageTask extends AsyncTask<String , String , String> {

            private Context context;
            private ProgressDialog pDialog;

            boolean bCancelled=false;
            public SaveImageTask(Context context) {
                this.context = context;
            }

            @Override
            protected void onPreExecute() {
                // TODO Auto-generated method stub

                super.onPreExecute();

                pDialog = new ProgressDialog(context);
                pDialog.setIndeterminate(false);
                pDialog.setCancelable(true);
                pDialog.setOnCancelListener(cancelListener);
                pDialog.show();

            }

            @Override
            protected String doInBackground(String... args) {
                // TODO Auto-generated method stub

                // MY STUFF
                return null;   
            }

            @Override
            protected void onPostExecute(String args) {
                // TODO Auto-generated method stub

                pDialog.dismiss();

            }

            OnCancelListener cancelListener=new OnCancelListener(){
                @Override
                public void onCancel(DialogInterface arg0){
                    bCancelled=true;
                    SaveImageTask.this.finish(); // <<----"The method finish() is undefined for the type SaveImageTask"
                }
            };


        }

score 3 · Answer 1 · answered Aug 31 '12 at 14:56

3

use SaveImageTask.this.finish();

answered Aug 31 '12 at 14:56

Shine

3,788
1
36
59

Now I get the error "The method finish() is undefined for the type SaveImageTask" – Android Novice Aug 31 '12 at 15:05
that is because `SaveImageTask` is not an activity. Refer to the enclosing activity to your AsyncTask class instead. – Vinay W Aug 31 '12 at 15:08

score 2 · Answer 2 · answered Aug 31 '12 at 15:02

 OnCancelListener cancelListener=new OnCancelListener(){
                @Override
                public void onCancel(DialogInterface arg0){
                    bCancelled=true;
                    finish(); // <<----"The method finish() is undefined for the type new DialogInterface.OnCancelListener(){}"
                }
            };

you are creating an anonymous class here. Only final variables and methods of the outer class are accessible inside an anonymous class directly. Activity 's finish is not a final method. What you need to do is reference the 'outer' class, which is an Activity and call its finish()

ActivityName.this.finish()

Note : you cannot make a static call like ActivityName.finish() hence the reference of activity's object this.

score 2 · Accepted Answer · answered Aug 31 '12 at 15:08

2

Just use,

(Activity(context)).finish();

EDIT:

Actually you have to cast your context to Activity Context,

then you can use finish() method of Activity,

Something like,

private Activity context;

public SaveImageTask(Context context) {
                this.context = (Activity)context;
            }

now, just

context.finish();

answered Aug 31 '12 at 15:08

user370305

108,599
23
164
151

I've already pass it on top. Got this error "The method Activity(Context) is undefined for the type new DialogInterface.OnCancelListener(){}" – Android Novice Aug 31 '12 at 15:10

Android finish() Activity Not working

3 Answers3

Linked