Write a sub class of Parcelable to another Parcel

Question

I have a class that implements Parcelable interface:

class A implements Parcelable {

}

I have another class B that contains an A object as an instance variable. In the writeToPacel inside class B, I want to write object B to the Parcel:

class B implements Parcelable{

    public void writeToParcel(Parcel dest, int flags) {
        dest.write ??? 
    }
}

How can I write and read it?

Where is the `A object` inside B? – iTurki Sep 02 '12 at 20:32 — iTurki, Sep 02 '12 at 20:32

score 173 · Accepted Answer · edited Nov 16 '16 at 20:54

173

class B implements Parcelable{
//lets assume you have A as a data member 

A obj;
public void writeToParcel(Parcel dest, int flags) {

        dest.writeParcelable(obj , flags);

    }
}

if you want to read it use this

 obj = in.readParcelable(A.class.getClassLoader());

edited Nov 16 '16 at 20:54

Shadab Ansari

7,022
2
27
45

answered Sep 02 '12 at 20:37

confucius

13,127
10
47
66

6

No need for casting :) – pablisco Jul 10 '14 at 11:41
4

You can be even more precise: `obj = (A) in.readParcelable(A.class.getClassLoader());` – caw Dec 09 '14 at 06:27
1

Casting is not required at al! – sud007 Sep 29 '16 at 13:48

pablisco · Answer 2 · 2015-04-24T09:55:59.637

A better way to handle this that avoids reflexion would be to simply call the static creator in the target type like this:

this.amazingObject = AmazingObject.CREATOR.createFromParcel(in);

and write it to the Parcelable using this.amazingObject.writeToParcel(Parcel, int)

Internally, when calling readParcelable(ClassLoader) this happens:

public final <T extends Parcelable> T readParcelable(ClassLoader loader) {
    Parcelable.Creator<T> creator = readParcelableCreator(loader);
    if (creator == null) {
        return null;
    }
    if (creator instanceof Parcelable.ClassLoaderCreator<?>) {
        return ((Parcelable.ClassLoaderCreator<T>)creator).createFromParcel(this, loader);
    }
    return creator.createFromParcel(this);
}

As you can see the last call of that method is just calling the right Creator but inside readParcelableCreator there is a whole lot of reflexion that we can avoid by just calling it directly.

This utility calls may be useful:

import android.os.Parcel;
import android.os.Parcelable;

public class Parcels {

    public static void writeBoolean(Parcel dest, Boolean value) {
        dest.writeByte((byte) (value != null && value ? 1 : 0));
    }

    public static Boolean readBoolean(Parcel in){
        return in.readByte() != 0;
    }

    public static void writeParcelable(Parcel dest, int flags, Parcelable parcelable) {
        writeBoolean(dest, parcelable == null);
        if (parcelable != null) {
            parcelable.writeToParcel(dest, flags);
        }
    }

    public static <T extends Parcelable> T readParcelable(Parcel in, Parcelable.Creator<T> creator) {
        boolean isNull = readBoolean(in);
        return isNull ? null : creator.createFromParcel(in);
    }

}

It throws an exception when the object is null, while ``readParcelable`` handles this situation correctly — dragoon, Dec 21 '14 at 13:31
I end up using my own Parcel Util but thanks for the inspiration! — Juan Saravia, Dec 12 '15 at 21:57

score 2 · Answer 3 · edited Feb 07 '14 at 06:25

The line:

obj = (A)in.readParcelable(A.class.getClassLoader());

should change to:

obj = (A)in.readParcelable(B.class.getClassLoader());

I encountered the same problem and did several Google search, many webpage or tutorial suggests we use A.class.getClassLoader() because we are casting to A, but actually it is WRONG because you will get a null value, we must use B.class.getClassLoader() because the codes are INSIDE class B. I just did not know why but it can get the correct A object in this way.

Welcome to comment and verify!!

Write a sub class of Parcelable to another Parcel

3 Answers3

Linked