3

I have a function inside a object that sets up a interval that calls another function but when ever that interval function is called it gives my a error saying Uncaught TypeError: Object [object Window] has no method

here is my code that I'm trying to understand.

function test2() {
this.timer;

this.say = function(){
    console.log("hi");
}

this.start = function() {
    //starts the interval function
    this.timer = setInterval(this.loop, 1000)
}

this.loop = function() {
    //runs every 1 second  
    this.say(); //gives error -- Uncaught TypeError: Object [object Window] has no method 'say'
}
}

var test = new test2();
test.start();

Thank you for your help!

Justin
  • 1,249
  • 1
  • 15
  • 37

2 Answers2

7

When setInterval() fires, the context is the global context (e.g. window), not your object. To call a method on your object and have the value of this set appropriately in that method call, you need a separate function where you can call the method on your actual object like this:

this.start = function() {
    //starts the interval function
    var self = this;
    this.timer = setInterval(function() {
        self.loop();
    }, 1000)
}

FYI, it is very common when using an asynchronous functions like timers or ajax to save the context this into a local variable so it can then be referenced from the embedded callback function even when this is different in the callback function (as in your example). This is a common design pattern.

jfriend00
  • 683,504
  • 96
  • 985
  • 979
0

I had a unique solution to this one. I got around it by making a function that calls my object method:

const globalSet = new globals();

function ut(){
    globalSet.updateToasts();
}

setInterval(ut,15000);

It seems to have tricked JS into doing what I wanted.

CttCJim
  • 76
  • 1
  • 6