ContextMenuStrip not closing once clicked

Question

I am creating a Context Menu Strip once a Rich Text Box is right clicked. There are 2 options, one to change the font and one to change the background color. However, once I click one of the menu options, the Context Menu Strip doesn't close and overlays dialogs that are displayed. I know I can make it "global" and force it to close, but I would rather not. What is the best way to handle this?

// If the console is right clicked then show font options
private void rtb_console_MouseUp(object sender, MouseEventArgs e)
{
    if (e.Button == System.Windows.Forms.MouseButtons.Right)
    {
        ContextMenuStrip menu = new ContextMenuStrip();
        menu.Items.Add("Change Font");
        menu.Items.Add("Change Background Color");
        menu.Show(this, new Point(e.X, e.Y));
        menu.ItemClicked += new ToolStripItemClickedEventHandler(menu_ItemClicked_ChangeFont);
    }
}  

// Determine whether to change the font or the font background color
void menu_ItemClicked_ChangeFont(object sender, ToolStripItemClickedEventArgs e)
{
    Application.DoEvents();  // Read that this might help, but it doesn't
    if (e.ClickedItem.Text == "Change Font")
    {
        FontDialog font = new FontDialog();

        font.ShowColor = true;
        font.Font = rtb_console.Font;
        font.Color = rtb_console.ForeColor;

        if (font.ShowDialog() == System.Windows.Forms.DialogResult.OK)
        {
            rtb_console.Font = font.Font;
            rtb_console.ForeColor = font.Color;
        }
    }
    else if (e.ClickedItem.Text == "Change Background Color")
    {
        ColorDialog color = new ColorDialog();
        color.Color = rtb_console.BackColor;

        if (color.ShowDialog() == System.Windows.Forms.DialogResult.OK)
        {
            rtb_console.BackColor = color.Color;
        }
    }
}

So this is what happens:
ContextMenuStrip Persisting

score 2 · Accepted Answer · edited May 23 '17 at 12:17

You don't want to create the ContextMenuStrip and show it manually each time. The better way to do this is to create the ContextMenuStrip once. Then assign it for the RichTextBox by assigning it to the ContextMenuStrip property of the RichTextBox. Doing this, you will no longer need to manually launch the ContextMenuStrip everytime a user clicks on it. It will occur automagically. It will also hide itself automagically in the way you would expect upon clicking on it.

Do this once and then remove your event handler for the MouseUp event:

ContextMenuStrip menu = new ContextMenuStrip(); 
menu.Items.Add("Change Font"); 
menu.Items.Add("Change Background Color"); 
menu.ItemClicked += new ToolStripItemClickedEventHandler(menu_ItemClicked_ChangeFont);
rtb_console.ContextStripMenu = menu;

Also, please please please don't use Application.DoEvents(); to try and force the UI to update itself. Head over to here and read the top answer. In general, if you are using Application.DoEvents(), you are doing something wrong and should considering changing your approach.

One thing you may also consider doing, but it is really just a matter of preference... If you are using Visual Studio, consider creating you ContextMenuStrip in the designer. That way, you can add your items, icons, and individual callbacks for each item very easily and visually. Just something I like to do out of pure personal preference.

I only put in `Application.DoEvents()` to see if that would work, but it didn't, also this line will not work: `menu.Show(this, new Point(e.X, e.Y));` with your code — Nick Sinas, Sep 19 '12 at 14:18
Sorry I meant to exclude that. Updated my code. The idea is that you don't need to manually show the context menu. The RTB will handle this for you when you assign your context menu to the ContextMenuStrip property. — Michael Mankus, Sep 19 '12 at 14:19
Ok well your code works, but with some small changes; `ContextMenuStrip menu = new ContextMenuStrip();` has to be declared globally and the rest has to be done inside `public MainForm()`, and it does not automagically hide itself, `menu.Close();` has to be added to the `menu_ItemClicked_ChangeFont` function. Once I did this it worked. — Nick Sinas, Sep 19 '12 at 14:26
You don't need to make `menu` global. Put the code I gave you in your `public MainForm()` and you can then access it anywhere by `rtb_console.ContextMenuStrip.Close();` — Michael Mankus, Sep 19 '12 at 14:28

score 2 · Answer 2 · edited Mar 27 '17 at 14:05

2

In ToolStripItemClickedEventArgs just declare:

ContextMenuStrip menu = (ContextMenuStrip)(Sender) 

if (e.ClickedItem.Text == "Change Font")
{
    menu.hide();
    /* and your code here*/...
}

edited Mar 27 '17 at 14:05

Troels Larsen

4,462
2
34
54

answered Mar 27 '17 at 11:05

Ermi

21
1

ContextMenuStrip not closing once clicked

2 Answers2