Crashing when I try to display a toast message, but does not crash in debugger

Question

I have been having a LOT of memory issues with my app. I'm trying to catch the memory exceptions and then display a message using toast saying out of memory.

When I run the app with the tast code it crashes. When I run it in the debugger, does not crash but no message comes up.

I'm trying to display the message within the catch memory exception inside the onCreate method of the Activty class.

code block:

public void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);


            // set size of card image
            ImageView CardImage = ( ImageView)findViewById(R.id.viewcard);
            int ScreenWidth=getWindowManager().getDefaultDisplay().getWidth();
            int ScreenHeight=getWindowManager().getDefaultDisplay().getHeight();

            // fix for tblets
            if (ScreenHeight<ScreenWidth)
               ScreenWidth=ScreenHeight;

            int CardWidth=ScreenWidth/2;
            CardWidth+=CardWidth/10;

            // set bitmap
        //    Bitmap bmp=BitmapFactory.decodeResource(getResources(), R.drawable.card2);
            String FileName=new String("card");
            FileName+=Integer.toString( CardId+1);
            FileName+=".jpg";


            // put in text that matches card
            TextView mCardText = (TextView)findViewById(R.id.cardtext);
            mCardText.setText( "Card Meaning \n"+ cCardText.mCardMeaning[ CardId]);

            // put in text that matches card
            TextView mHouseText = (TextView)findViewById(R.id.housetext);
            mHouseText.setText( "House Meaning \n"+ cCardText.mHouseMeaning[ HouseId-1]);

        try {
       AssetManager assetManager= getAssets();
       InputStream inputStream;
       inputStream=assetManager.open(FileName);  
       Bitmap icon=BitmapFactory.decodeStream(inputStream);
       CardImage.setImageBitmap(icon);
        } catch( OutOfMemoryError e)
        {
    /////////////////////////////////////////////////////////////////////
    // crashes heare
            Context context = getApplicationContext();
            CharSequence text = "Out of Memory  ";
            int duration = Toast.LENGTH_SHORT;

            Toast toast = Toast.makeText(context, text, duration);
            toast.show();  

            gi++;
              return;
        } catch (IOException e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
            return;
        } 


        //scale it
        // note: only code here that pertains to card image, becouse if card image cannot be loaded
        // the above exceptions will go off and we will never get here
        CardImage.getLayoutParams().width=CardWidth;
        CardImage.getLayoutParams().height = (int)( (float) CardWidth *1.7);


    }

Activity extends Context which means instead of `context = getApplicationContext()` you can simply use `this` in your catch block. — WarrenFaith, Sep 24 '12 at 22:10

score 1 · Accepted Answer · edited May 23 '17 at 10:24

1

When you are OutOfMemory, all bets are pretty much off because at that point the JVM cannot really allocate any new memory. So it's likely crashing due to that reason.

You might want to try clearing out some pointers before displaying the message... but I've never seen anyone actually try to catch an OutOfMemory error.

The 3rd answer down here in this post Is it possible to catch out of memory exception in java? explains a bit why its a really bad idea to try to catch outofmemory exceptions.

edited May 23 '17 at 10:24

Community

1
1

answered Sep 24 '12 at 22:03

Nicholas DiPiazza

10,029
11
83
152

Try catching the low memory broadcast and display the toast then. Ooops. Not really catch. Receive. – Howard Hodson Sep 24 '12 at 22:35

Crashing when I try to display a toast message, but does not crash in debugger

1 Answers1