How is it possible to have ClassCastException after instanceof returns true

Question

I am getting the following code snippet from Android's Pair.java

public boolean equals(Object o) {
    if (o == this) return true;
    if (!(o instanceof Pair)) return false;
    final Pair<F, S> other;
    try {
        other = (Pair<F, S>) o;
    } catch (ClassCastException e) {
        return false;
    }
    return first.equals(other.first) && second.equals(other.second);
}

I was wondering, how is it possible to have ClassCastException, after instanceof returns true.

check your import. Maybe you are importing two different Pair class — Blackbelt, Sep 25 '12 at 14:09
You aren't getting a `ClassCastException`, are you? It should be impossible in this case. Just because you found code somewhere that catches some random exception doesn't mean this exception can actually be thrown. — David Wasser, Sep 25 '12 at 14:33
It's possible your F and/or S class is the one throwing the ClassCastException. Post full code sample or a stack trace, please. — KJP, Sep 25 '12 at 14:47
Full code is already posted as external link in the question. That's the official code from Android — Cheok Yan Cheng, Sep 25 '12 at 15:22
What are `F` and `S`? I suspect their `equals` implementations of being the ones throwing the CCE. — Louis Wasserman, Sep 25 '12 at 15:52

score 3 · Accepted Answer · answered Sep 25 '12 at 14:36

3

It isn't possible. The code makes no sense. Whoever wrote it probably didn't understand that F and S are erased at runtime so a ClassCastException could never happen.

answered Sep 25 '12 at 14:36

artbristol

32,010
5
70
103

The code are from Google Android engineers. Possible they see something we don't notice? – Cheok Yan Cheng Sep 25 '12 at 15:24
Same guess from me. Anyone can go wrong, including Googlers :) – Cheok Yan Cheng Oct 09 '12 at 05:19

How is it possible to have ClassCastException after instanceof returns true

1 Answers1