Check input is a valid integer

Question

Hi Can anyone help me please. I need to check that my input only contains integers. Im guessing from looking it up that I use the isDigit function but I am not sure how to use this to check the whole number.

I'm using C++ to interact with MSI so i'm getting the integer as follows:

hr = WcaGetProperty(L"LOCKTYPE",&szLockType);
ExitOnFailure(hr, "failed to get the Lock Type");

I think i have to change szLockType to a char and then use isdigit to scan through each character but i am not sure how to implement this. Any help would be greatly appreciated. P.s im a beginner so please excuse if this is a really trivial question..:)

http://en.cppreference.com/w/cpp/string/basic_string/stol will perform the conversion, and throw an exception if it can't. — BoBTFish, Sep 28 '12 at 11:13

score 2 · Answer 1 · answered Sep 28 '12 at 11:15

2

Use std::stoi(). You'll get an exception if the string is not an integer value.

answered Sep 28 '12 at 11:15

BЈовић

62,405
41
173
273

No, it won't check that the input is a valid integer, only that it has a non-whitespace prefix that is a valid integer, e.g: `std::stoi(" 123broohaha ")` will return 123, but `std::stoi(" broohaha123 ")` will throw. – malenkiy_scot Oct 03 '13 at 15:15

Philipp · Accepted Answer · 2012-09-28T11:22:10.010

0

What's the type of szLockType?

Is it a a null-terminated char-string?

Then you can use the array syntax to get individual characters.

for(int i = 0; i < std::strlen(szLockType); i++) {
    if(!std::isDigit(szLockType[i])) {
         // it contains a non-digit - do what you have to do and then...
         break; // ...to exit the for-loop
    }
}

Or is it a std::string? Then the syntax is slightly different:

for(int i = 0; i < szLockType.length(); i++) {
    if(!std::isDigit(szLockType.at(i)) {
         // it contains a non-digit - do what you have to do and then...
         break; // ...to exit the for-loop
    }
}

edited Sep 28 '12 at 11:22

answered Sep 28 '12 at 11:16

Philipp

67,764
9
118
153

The value I am getting is a `TCHAR*` will this still work? I tried the first one and even converted it to a char but i wanted a char*. – Natalie Carr Sep 28 '12 at 11:33
Changed it so that is an int..:) – Natalie Carr Sep 28 '12 at 11:36
depending on the plattform, tchar is either a synonym for char (1-byte ASCII-characters) or for wchar (2-byte unicode-characters): http://msdn.microsoft.com/en-us/library/office/cc842072.aspx. The function to get the length of a wchar string is std::wcslen. The wchar version of isdigit is iswdigit. – Philipp Sep 28 '12 at 11:42
Its windows..:) `szLockType` is now an int so il look into converting that. Thanks – Natalie Carr Sep 28 '12 at 11:46

score 0 · Answer 3 · answered May 12 '22 at 19:58

Even better, with modern C++ you can do this:

#include <algorithm>
#include <cctype>

auto lambda = [](auto elem)
{
    return std::isdigit(elem);
};

return std::all_of(szLockType, szLockType + strlen(szLockType), lambda);

Your choice as to whether you prefer a named lambda or regular, anonymous lambda.

FYI it is std::isdigit rather than isDigit.

https://en.cppreference.com/w/cpp/string/byte/isdigit

Check input is a valid integer

3 Answers3