4

I am trying to update table Original with the values in Final. I'm new to SQL, but I have been at this for two hours trying to change various samples to fit my needs. I am using Access 2007.

UPDATE
  Original o
SET
  o.[Assest Description] = (
    SELECT f.[Assest Description] FROM Original o, Final f
    WHERE o.[Assest No] = f.[Assest No])
WHERE o.[Assest No] = Final.[Asset No]
Peter Mortensen
  • 30,738
  • 21
  • 105
  • 131
Hamptonite
  • 109
  • 1
  • 1
  • 8

3 Answers3

9

I'm not sure your select statement returns only one row. If you want to perform an update on a table using a select statement for assignment, you must be sure that it returns only one row.

Besides that, you may consider the next solution:

update 
   Original as o
   inner join Final as f on o.[Assest No] = f.[Assest No]
set
   o.[Assest Description] = f.[Assest Description]

Notice that this will only work correctly if both [Assest no] is a unique key in both Original and Final tables, and they are properly related.

Barranka
  • 20,547
  • 13
  • 65
  • 83
  • Certainly cmsjr's answer is simpler – Barranka Oct 04 '12 at 23:07
  • I'm not totally sure my answer will work with the Access engine, so your answer may be the better one. – cmsjr Oct 04 '12 at 23:09
  • This totally worked and saved my hind quarters. I've tried cmsjr answer, and I thought it was that easy, but it isn't. Thank you both. I'm bad with SQL, but the join statements make me zone out. – Hamptonite Oct 05 '12 at 01:40
  • @user1721535 I'm glad to know that this helped you. Just one more little (and very personal) opinion: MS Access SQL is a very customized SQL dialect (I call it "Bill's SQL")... It's a good place to learn the basics, but it has some tricks that can be confusing – Barranka Oct 06 '12 at 06:07
  • 2
    Based on this I made the following query in Access 2013 and it worked great: `UPDATE Components INNER JOIN Analysis ON Components.Component = Analysis.Component SETComponents.BusinessUnit = Analysis.[Test Area], Components.Impact = Analysis.Impact, Components.InScope = SWITCH (Analysis.[Test Area] = "NA", False, True, True), Components.InUse = SWITCH (Analysis.[Test Area] = "Not Used", False, True, True)` – Shanerk Oct 16 '14 at 21:50
2

Try this

UPDATE o 
SET o.[Assest Description] =  f.[Assest Description]
FROM Original o, Final f WHERE o.[Assest No] = f.[Assest No]
cmsjr
  • 56,771
  • 11
  • 70
  • 62
  • 3
    Just as a note -> this query syntax doesn't work for MS Access 2007 – John M May 22 '15 at 19:34
  • 1
    It should throw error #3075, *"Syntax error (missing operator) in query expression ..."*. A valid Access SQL `UPDATE` does not include the `FROM` keyword, and you must fully define the data source(s) before `SET`. – HansUp Jun 04 '15 at 19:00
  • 3
    This doesn't work for Access 2013 either, same error as pointed out by @HansUp – ThisClark Aug 22 '15 at 19:26
0

Access is horribly picky. If you fully qualify the name of the field you are updating it may fails. If you don't fully qualify joins tables and fields, it may come back with "join not supported". I say may because it's likely slightly different versions will do something different. At least that's my experience.

So my answer is start with CreateQuery Design. Pick the two tables and get the select working correctly. Then modify it to an update query and make the update to of the column(s) you want to update the fields from the table you want to update from. Then switch to SQL view and use that as the model to build your query in VBA.

I had a syntactically correct SQL statement, but until I did this and then matched the qualifying vs. non-qualified field names exactly, it claimed join is not supported.

Peter Mortensen
  • 30,738
  • 21
  • 105
  • 131
billpennock
  • 441
  • 1
  • 6
  • 14