Friendly_id not creating slugs for old records

Question

I just added the Friendly_id gem to my rails project looking to not use the database id and create a slug, but I can't seem to create slugs for old records. My model looks like this.

class Mapping < ActiveRecord::Base

  extend FriendlyId
  friendly_id :title, use: :slugged

  # Friendly_Id code to only update the url for new records
  def should_generate_new_friendly_id?
    new_record? || slug.blank?
  end

end

I then am running Model.find_each(&:save) but it keeps spitting out a nil result. I've tried commenting out the should_generate_new_friendly_id completely but with no luck. Anyone see what I'm doing wrong here?

EDIT
I rolled my database back and rewrote my migratations and that has appeared to have fixed the issue.

Have you tried to return constant `true` in `should_generate_new_friendly_id?` just for generating slug for the old records? — Matzi, Oct 09 '12 at 20:49
Could you clarify what you mean here? I'm still pretty new to rails. — rigelstpierre, Oct 09 '12 at 20:53
I mean to regenerate nonexisting slugs with this: `def should_generate_new_friendly_id?; true; end` Also, I hope you used `Mapping.find_each(&:save)` and not `Model.find_each(&:save)`. — Matzi, Oct 09 '12 at 20:54
Change the code in the model to the one I wrote, and run the `Mapping.find_each(&:save)` from the console, after you saved the changed model. — Matzi, Oct 09 '12 at 20:57
I was using `Mapping.find_each(&:save)`, even with your code I'm the application is still retuning nil — rigelstpierre, Oct 09 '12 at 21:09
i have slugs in 2 models, it is working for 1 model but not for 2nd, the function `should_generate_new_friendly_id` not event get called. — Muhamamd Awais, Mar 28 '13 at 07:22
Try: "new_record? || slug.nil?" in your should_generate_new_friendly_id — bulleric, Dec 04 '14 at 16:02

score 2 · Answer 1 · answered Jul 31 '19 at 15:44

2

If anyone finds this 6 year old question:

Without a "do and end" block:

find_each returns an Enumerable (not an ActiveRecord Class)

Use:

Model.find_each.select(&:save)

Notice the added "select" method

Doing stuff with Rails’ find_each

answered Jul 31 '19 at 15:44

Ruecktenwald

141
3

Friendly_id not creating slugs for old records

1 Answers1