14

I'm putting a value into TempData on first request in an actionfilter.

filterContext.Controller.TempData["value"] = true;

after that a second request comes in and I check for the value

filterContext.Controller.TempData.ContainsKey("value")

the value is there. Then a third request comes in and I check for the value again

filterContext.Controller.TempData.ContainsKey("value")

and the value is still present. Shouldn't be this value destroyed after the second request ? All request are AJAX requests.

user49126
  • 1,825
  • 7
  • 30
  • 53

1 Answers1

37

Shouldn't be this value destroyed after the second request ?

Only if you read it:

var value = filterContext.Controller.TempData["value"];

If you don't read the value from the TempData it won't be evicted.

Here's how the TempData.Items getter is defined:

public object get_Item(string key)
{
    object obj2;
    if (this.TryGetValue(key, out obj2))
    {
        this._initialKeys.Remove(key);
        return obj2;
    }
    return null;
}

Notice how the value will be evicted only if you call the getter and only if the value was found in the collection. In the code you have shown all you do is check whether the TempData contains a given key but you haven't read the value of this key.

You could manually evict the TempData value if you want:

filterContext.Controller.TempData.Remove("value");

And there's also a method which allows you to read the value without removing it:

var value = filterContext.Controller.TempData.Peek("value");
Darin Dimitrov
  • 1,023,142
  • 271
  • 3,287
  • 2,928
  • That's very strange. Most other resources say: It's lifetime is only one request. Found out today the hard way. Seems to be changed in [MVC2-3](https://stackoverflow.com/a/5970364/2441442). Later on in [MVC 4](https://stackoverflow.com/a/13997133/2441442) some other statement, and in MVC5, well, its working as described above. – Christian Gollhardt Jun 22 '23 at 18:31