Java call constructor from constructor

Question

I have a constructor

private Double mA;
private Double mB;

Foo(Double a) {
  mA = a;
  mB = a + 10;
}

Foo(Double a, Double b) {
  mA = a;
  mB = b;
  // some logic here
}

if I make a call to second constructor like this:

Foo(Double a) {
  Double b = a + 10;
  this(a, b);
}

than compiler tells me, that constructor should be the first statement. So do I need to copy all logic from the second constructor to first one?

Possible duplicate of https://stackoverflow.com/questions/285177 — EmJiHash, Aug 29 '17 at 08:22

score 26 · Accepted Answer · answered Oct 14 '12 at 08:16

26

Why don't you just do this(a, a+10) instead?

Note that this() or super() must be the first statement in a constructor, if present. You can, however, still do logic in the arguments. If you need to do complex logic, you can do it by calling a class method in an argument:

static double calculateArgument(double val) {
    return val + 10; // or some really complex logic
}

Foo(double a) {
    this(a, calculateArgument(a));
}

Foo(double a, double b) {
    mA = a;
    mB = b;
}

answered Oct 14 '12 at 08:16

nneonneo

171,345
36
312
383

It is simplified example. In general I can have something like: b = callToFunction(boo(bar(a))) – user1284151 Oct 14 '12 at 08:18
@nneonneo: +1 for static `calculateArgument`, non-overridable. – Bhesh Gurung Oct 14 '12 at 08:26
1

I think it is not because it is non-overridable, but because you just can't call instance method in this()/super() – Le_Coeur Dec 16 '13 at 09:43

score 6 · Answer 2 · answered Oct 14 '12 at 08:16

If you use this() or super() call in your constructor to invoke the other constructor, it should always be the first statement in your constructor.

That is why your below code does not compile: -

Foo(Double a) {
  Double b = a + 10;
  this(a, b);
}

You can modify it to follow the above rule: -

Foo(Double a) {
  this(a, a + 10);  //This will work.
}

Subhrajyoti Majumder · Answer 3 · 2012-10-14T08:30:48.253

2

Invocation of another constructor must be the first line in the constructor.

You can call explicit constructor invocation like -

Foo(Double a) {
  this(a, a+10);
}

edited Oct 14 '12 at 08:30

answered Oct 14 '12 at 08:16

Subhrajyoti Majumder

40,646
13
77
103

Java call constructor from constructor

3 Answers3

Linked