ProgressDialog not showing while performing a task

Question

I have a backup routine that copies everything from one folder to an external SD card which works perfectly. I'm trying to get an nice popup dialog box that shows when it's running but it just isn't showing. Doesn't even attempt to run (but the backup does complete).

Here's my code at the moment:

public void doBackup(View view) throws IOException{
    ProgressDialog pd = new ProgressDialog(this);
    pd.setProgressStyle(ProgressDialog.STYLE_SPINNER);
    pd.setMessage("Running backup. Do not unplug drive");
    pd.setIndeterminate(true);
    pd.setCancelable(false);
    pd.show();
    File source = new File("/mnt/extSdCard/DirectEnquiries"); 
    File dest = new File("/mnt/UsbDriveA/Backup");
    copyDirectory(source, dest);
    pd.dismiss();
}

are you calling this method in onCreate()????? – maninder singh Oct 15 '12 at 14:01 — maninder singh, Oct 15 '12 at 14:01
It's being called on a button press – MissCoder87 Oct 15 '12 at 14:07 — MissCoder87, Oct 15 '12 at 14:07

score 41 · Accepted Answer · edited Jul 24 '16 at 11:11

41

You run long running tasks in a Thread or with an AsyncTask. Then your ProgressDialog will show up.

Do something like:

public void doBackup(View view) throws IOException{
    final ProgressDialog pd = new ProgressDialog(this);
    pd.setProgressStyle(ProgressDialog.STYLE_SPINNER);
    pd.setMessage("Running backup. Do not unplug drive");
    pd.setIndeterminate(true);
    pd.setCancelable(false);
    pd.show();
    Thread mThread = new Thread() {
        @Override
        public void run() {
            File source = new File("/mnt/extSdCard/DirectEnquiries"); 
            File dest = new File("/mnt/UsbDriveA/Backup");
            copyDirectory(source, dest);
            pd.dismiss();
        }
    };
    mThread.start();
}

edited Jul 24 '16 at 11:11

Sufian

6,405
16
66
120

answered Oct 15 '12 at 14:14

maninder singh

1,286
13
16

can you explain why we should put pd.dismiss(); inside the thread I used mThread.join() and I put the pd.dismiss() after it put it doesn't work ? – Mohammed Subhi Sheikh Quroush Apr 02 '14 at 11:30
The showing and dismissing of the ProgressDialog object should be done with a handler, since only the original thread can touch the view. – ılǝ Aug 20 '14 at 09:03

score 2 · Answer 2 · answered Oct 15 '12 at 14:09

Create a asyntask and put your time consuming tasks

 public void doBackup(View view) throws IOException{
        ProgressDialog pd = new ProgressDialog(this);
       pd.setProgressStyle(ProgressDialog.STYLE_SPINNER);
        pd.setMessage("Running backup. Do not unplug drive");
       pd.setIndeterminate(true);
       pd.setCancelable(false);
        pd.show();
//create asyntask here
//Put below code in doInBackground mathod
        File source = new File("/mnt/extSdCard/DirectEnquiries"); 
        File dest = new File("/mnt/UsbDriveA/Backup");
        copyDirectory(source, dest);
//put this code in onPostExecute Method.
        pd.dismiss();
    }

You will get number of samples of Asyntask.

score 1 · Answer 3 · answered Oct 15 '12 at 14:13

Instead of doing this in one function at once. Do the following steps and it will definately work for you. 1. Create one async class.(It will create one separate thread for your copy directory functionality and wont run on main UI.) 2. Show your progress dialog before you execute the async class. 3. On post execute method, dismiss your dialog.

ProgressDialog not showing while performing a task

3 Answers3

Linked