UIScrollView won't adjust height to fit subviews

Question

I have a UITextView, which sets its text dynamically from an RSS feed. The textview is a subview of a UIScrollview. Ultimately, I am creating a mobile newspaper app, so the user should be able to scroll through the text (and other subviews).

After creating the views in IB, I added

NSString *sourceCode = [NSString stringWithContentsOfURL:[NSURL URLWithString:self.URL] encoding:NSUTF8StringEncoding error:&error];
sourceCode = [self parseHTMLText:sourceCode];
CGSize maximumLabelSize = CGSizeMake(320,9999);
CGSize txtStringSize = [sourceCode sizeWithFont:self.body.font
                              constrainedToSize:maximumLabelSize];
CGRect newlblFrame = CGRectMake(0, 0, 320, txtStringSize.height);
self.body.frame = newlblFrame; //body is the textview
self.body.text = sourceCode;
self.scroll.contentSize=CGSizeMake(320, self.body.frame.size.height+300); //scroll is scrollview

A typical NSLog will display body frame = {{0, 0}, {320, 2088}} scrollview frame = {{0, 0}, {320, 417}} scrollview content size = {320, 2388}

However, when I run the app, body maintains its interface builder height of around 196 and the scrollview won't scroll (when i move it, it just bounces back to its original position)

On a side note, when I try to manually change the frame of the textview with CGRectMake, the NSLog shows the correct height, but the view doesn't appear different. I made sure that it's hooked up correctly in IB, because I can adjust other properties, like background color.

EDIT:

After I set the cliptoBounds property of the textview to NO, the textview now adjusts its height and tries to show the entire text. However, it cuts off at the end of the screen, and I still cannot scroll.

Here is what I see currently. I made the scrollview background color gray for convenience. I'm not sure why part of the scrollview is partially in white and and partially gray. (Title) is a separate label btw)

enter image description here

Change scrollview contentSize after you print the text on the UIlabel. I think it should solve your issue. — iCreative, Oct 23 '12 at 07:00
I tried adding it after body.text = ... but the results are the same — Mahir, Oct 23 '12 at 07:10
add one more line into the code: self.body.numberOfLines = 0; After self.by.frame = newlblFrame; I am also editing the code above. — iCreative, Oct 23 '12 at 07:52
I already set that in interface builder, but I also tried adding it in code. Same results — Mahir, Oct 23 '12 at 07:57
are you setting it 0?? or some other value. Also put a NSLog after getting new frame for the label. and see what is coming. It is same as old frame or it is being updated. — iCreative, Oct 23 '12 at 08:01
Yes, it is 0. The NSLog shows that the same frame for the label — Mahir, Oct 23 '12 at 19:45
By the way, I realized I needed a UITextView, so I changed the UILabel to a UITextView. I've also added some more details to the question — Mahir, Oct 24 '12 at 02:20
let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/18511/discussion-between-icreative-and-mahir) — iCreative, Oct 24 '12 at 08:37
Can you provide the frame of your scrollview??? Make Sure the Scrollview frame is not more than your screen resolution i,e (320x460 px). — iCreative, Oct 24 '12 at 08:40
Have you checked the AutoresizingMask property of UITextView in IB? Is it fixed or flexible? Also in which method are you doing the above frame calculation and setting thing? — iDev, Oct 26 '12 at 07:01

score 5 · Accepted Answer · edited May 23 '17 at 10:32

5

I fixed the problem by moving the code from viewDidLoad to viewDidAppear. Apparently this is an Xcode 4.5 specific issue, resulting from the AutoLayout feature overriding the logic in the viewDidLoad method. A better explanation can be found here.

edited May 23 '17 at 10:32

Community

1
1

answered Oct 26 '12 at 22:52

Mahir

1,684
5
31
59

score 3 · Answer 2 · answered Oct 23 '12 at 06:37

3

i hope this will help you

self.scrollview.contentSize=CGSizeMake(320, label.frame.size.height+30);

answered Oct 23 '12 at 06:37

ganesh manoj

977
10
24

The scrollview's frame doesn't change – Mahir Oct 23 '12 at 06:45
it will not change scrollview size it will increase scrollview content size – ganesh manoj Oct 23 '12 at 06:53
What I meant was that I still can't scroll through all the text – Mahir Oct 23 '12 at 07:10
give all label total size here.then will get entire scrollview – ganesh manoj Oct 23 '12 at 07:27

score 1 · Answer 3 · edited Nov 29 '12 at 14:58

1

Try to add this :

[_scrollView setClipsToBounds:YES];

edited Nov 29 '12 at 14:58

Techie

44,706
42
157
243

answered Nov 29 '12 at 14:39

Svyat Zubyak

11
2

score 0 · Answer 4 · answered Oct 23 '12 at 07:17

Try this:

CGSize maximumSize = CGSizeMake(200.0, 30.0); // Specify your size. It was for my screen. 
            UIFont *txtFont = <Ur Font size & Var>;
            //new
            //fontValue = txtFont;
            //new

            lblValue.font = txtFont; 
            lblValue.lineBreakMode = UILineBreakModeWordWrap;

            CGSize txtStringSize = [commentTxt sizeWithFont:txtFont 
                                          constrainedToSize:maximumSize 
                                              lineBreakMode:lblValue.lineBreakMode];

            CGRect newlblFrame = CGRectMake(105.0, y, 200.0, txtStringSize.height);

            lblValue.frame = newlblFrame;          
            lblValue.text = @"Your String";

After this set scroll Content size. Hope it'll work for you. It worked for me.

I tried, but it still isn't working. I will add the code above — Mahir, Oct 23 '12 at 07:39

score 0 · Answer 5 · answered Oct 26 '12 at 10:12

0

Try to solve in the following way.

// adjust the height of UITextView with content height
CGRect frame = self.body.frame;
frame.size.height = self.body.contentSize.height;
self.body.frame = frame;

// adjust UIScrollView's height with the height of UITextView
self.scroll.frame = frame;

answered Oct 26 '12 at 10:12

Thein Hla Maw

685
1
9
28

never mind, I solved it. I posted the solution as a separate answer. – Mahir Oct 26 '12 at 22:53

UIScrollView won't adjust height to fit subviews

5 Answers5