"Must declare the scalar variable" for parameter (C# SqlCommand)

Question

string selectedAreas = getSelectedAreas(areaCounts);

SqlConnection cn = new SqlConnection(connectionstring);
SqlCommand cmd = new SqlCommand();
cmd.CommandText = "select top 1 [x1] " +
                  "from sometable " +
                  "where sometable.coll = @selectedAreas" +
                  "order by NEWID() ";
cmd.CommandType = System.Data.CommandType.Text;
cmd.Connection = cn;
cmd.Parameters.AddWithValue("@selectedAreas", selectedAreas);

What am I doing wrong here?

I get

Must declare the scalar variable for @selectedAreas.

@selectedAreas might become something like:

" 'nyc' or sometable.coll = 'la' or sometable.coll = 'miami' "

Edit:

I added the space as the comment below pointed out. And removed the paramter, like this:

cmd.CommandText = "select top 1 [x1] " +
                  "from sometable " +
                  "where sometable.coll = " + selectedAreas
                  " order by NEWID() ";

Dont know how correct it is but it works for now...

You need a space after `@selectedAreas` in your SQL. As for your value, it isn't going to work. — Anthony Pegram, Oct 31 '12 at 12:27
For the second part of the problem, perhaps [this question](http://stackoverflow.com/questions/337704/parameterizing-an-sql-in-clause) might be a starting point. For your edited approach, please find the delete button. — Anthony Pegram, Oct 31 '12 at 13:55

score 1 · Answer 1 · edited May 23 '17 at 11:48

1

It could be the way you are running the command (which you didn't include in your question), such as in this case: Must Declare Scalar Variable

edited May 23 '17 at 11:48

Community

1
1

answered Oct 31 '12 at 14:18

Tobberoth

9,327
2
19
17

"Must declare the scalar variable" for parameter (C# SqlCommand)

1 Answers1