SharedPreferences keep getting default value

Question

I keep Getting the Default value either my UI will display null or if I use integers it displays that default value as well here it is in the string form plz help

//putting the information in shared preferences
TextView pScore1=(TextView)findViewById(R.id.pScore1f);


SharedPreferences peepsScores2= PreferenceManager.getDefaultSharedPreferences(GamePlayFirst.this);
SharedPreferences.Editor editor2 =peepsScores2.edit();
String userScore11 = pScore1.getText().toString();
  editor2.putString("userScore11",userScore11);
  editor2.commit();

  //getting it and editing it

  SharedPreferences peepsScores2 = PreferenceManager.getDefaultSharedPreferences(this);
    int u;
    int one =1;
    int newUsrScore1=1;
    String userScore11 = peepsScores2.getString("userScore11",null);
    u=Integer.parseInt(userScore11);
        newUsrScore1 = u+one;
        String newUserScore1  = Integer.toString(newUsrScore1);

    SharedPreferences.Editor editor = peepsScores2.edit();
    editor.putString(newUserScore1, NewUserScore1);
      editor.commit();

    //getting it and displaying it on the UI

    SharedPreferences peepsScores2 = PreferenceManager.getDefaultSharedPreferences(this);
    String userScore11 = peepsScores2.getString("NewuserScore1",null);


  pScore1.setText(" "+userScore11);

try looking at the xml and see whether commit is successful. — onemach, Oct 31 '12 at 12:29

score 1 · Answer 1 · answered Oct 31 '12 at 12:31

1

This line

editor.putString(newUserScore1, null);

should be

editor.putString("NewuserScore1",newUserScore1);

and also don't forget to commit your changes using editor.commit();

answered Oct 31 '12 at 12:31

Anup Cowkur

20,443
6
51
84

commit isthere i missed it on the cop paste and when i changed the null to newUserScore1 it still says null in my UI – BRK Oct 31 '12 at 12:38
capitol N haha im the worst typer ever ty – BRK Oct 31 '12 at 12:47

score 1 · Accepted Answer · answered Oct 31 '12 at 12:32

I have added some comment to you code please check:

//putting the information in shared preferences
TextView pScore1=(TextView)findViewById(R.id.pScore1f);


SharedPreferences peepsScores2= 

PreferenceManager.getDefaultSharedPreferences(GamePlayFirst.this);
SharedPreferences.Editor editor2 =peepsScores2.edit();
String userScore11 = pScore1.getText().toString();
  editor2.putString("userScore11",userScore11);
  editor2.commit();

  //getting it and editing it

  SharedPreferences peepsScores2 = PreferenceManager.getDefaultSharedPreferences(this);
    int u;
    int one =1;
    int newUsrScore1=1;
    String userScore11 = peepsScores2.getString("userScore11",null);
    u=Integer.parseInt(userScore11);
        newUsrScore1 = u+one;
        String newUserScore1  = Integer.toString(newUsrScore1);

    SharedPreferences.Editor editor = peepsScores2.edit();

     //@Praful: here newUserScore1 seems to be integer value and you are storing 
    //null here. I think it it should be 
    //`editor.putString("NewuserScore1", newUsrScore1);`
    editor.putString(newUserScore1, null);

     //@Praful: call commit here
    editor.commit;

    //getting it and displaying it on the UI

    SharedPreferences peepsScores2 = PreferenceManager.getDefaultSharedPreferences(this);
    String userScore11 = peepsScores2.getString("NewuserScore1",null);


  pScore1.setText(" "+userScore11);

this answer solved my similar problem too, I forget to put in editor.commit(); after adding that it worked!! :) thanks — Andrew Irwin, May 18 '16 at 10:04

score 0 · Answer 3 · edited Oct 31 '12 at 12:36

0

Whenever you working with SharedPreference never forget to call commit() to save your changes.

    SharedPreferences.Editor editor = peepsScores2.edit();
    editor.putString("NewuserScore1", newUserScore1);
    editor.commit();

edited Oct 31 '12 at 12:36

Mohammed Azharuddin Shaikh

41,633
14
96
115

answered Oct 31 '12 at 12:31

J.D.

1,401
1
12
21

SharedPreferences keep getting default value

3 Answers3

Linked