Passing variable in PHP link

Question

Possible Duplicate:
php - insert a variable in an echo string

I have a link that when it is clicked calls the next page and should pass two varibles to the page, the first is Manu and the second is fuel_type.

The problem is I can not seem to get the code to identify the variables and instead it passes the dollar sign and the variable name and not the value.

The code is below, i have tried writing this several different ways, but I am just running out of ideas.

 .'<a href=\act/manufacturer.php?manufacturer=$manu&fuel_type=$fuel_type>'.$manu.'</a>'.

You forgot to read the PHP documentation. The PHP manual quite clearly explains how variables are interpolated inside strings. In this case the difference between `'` and `"` is key. Please go read the manual... — Lightness Races in Orbit, Nov 05 '12 at 01:14

Tim Post · Answer 1 · 2012-11-05T01:54:59.187

First, be sure that the variables contain what you want (from the superglobal GET variable):

$manu = $_GET['manu'];
$fuel_type = $_GET['fuel_type'];

Then, you have two options:

Use double quotes " instead of single quotes, variables inside of quotes will be expanded
```
"My dog is named $dog_name, and is $dog_age years old";
```

Concatenate the strings inside single quotes with variables:

'My dog is named ' . $dog_name . ', and is ' . $dog_age . ' years old.';

Be absolutely certain, however that you sanitize the variables before using or displaying them to the browser. At a minimum, you want any HTML/JS code removed, then some checking to make sure the result is of the type and length that you expect. There are quite a few questions on SO discussing ways to do this, a quick search for [php] sanitize GET variables will turn them up.

score 2 · Answer 2 · answered Nov 05 '12 at 01:13

2

Single quotes do not parse variables, while double quotes do. Change your quotes around, and your link should work correctly.

Example:

."<a href=\act/manufacturer.php?manufacturer=$manu&fuel_type=$fuel_type>".$manu.'</a>'.

answered Nov 05 '12 at 01:13

Daedalus

7,586
5
36
61

score 2 · Accepted Answer · answered Nov 05 '12 at 01:13

2

you have to insert the var outside the '

like this:

.'<a href=\act/manufacturer.php?manufacturer='.$manu.'&fuel_type='.$fuel_type.'>'.$manu.'</a>'.

answered Nov 05 '12 at 01:13

gabrielem

560
5
13

nickhar · Answer 4 · 2012-11-05T01:20:39.387

2

Single quotes dont allow parsing of variables, double-quotes do. So you'd be better off doing something like:

"<a href=\act/manufacturer.php?manufacturer=$manu&fuel_type=$fuel_type>$manu</a>";

-- or in your case --

'<a href=\act/manufacturer.php?manufacturer='.$manu.'&fuel_type='.$fuel_type.'>'.$manu.'</a>'

edited Nov 05 '12 at 01:20

answered Nov 05 '12 at 01:15

nickhar

19,981
12
60
73

this is the sum of mine and Daedalus's – gabrielem Nov 05 '12 at 01:20
@gabrielem Yeah. Great minds... – nickhar Nov 05 '12 at 01:22

score -1 · Answer 5 · answered Nov 05 '12 at 01:16

-1

You can wrap your variables around curly braces to escape variable expressions:

'<a href=\act/manufacturer.php?manufacturer={$manu}&fuel_type={$fuel_type}>'.$manu.'</a>'.

answered Nov 05 '12 at 01:16

Lock

5,422
14
66
113

3

This however _will not_ work. – Daedalus Nov 05 '12 at 01:22

Passing variable in PHP link

5 Answers5