Twitter Bootstrap checkbox-button value changed after click event

Question

I have a checkbox-button-group like this:

<div class="btn-group" id="id_group" data-toggle="buttons-checkbox">
  <button class="btn myclass" type="button" data-value="0">Value 0</button>
  <button class="btn myclass" type="button" data-value="1">Value 1</button>
</div>

And the JS event handler:

$(".myclass").click(function(event) {
  console.log($(".myclass.active").length);
  console.log($(this).hasClass("active"));
});

I want to get the data-value for all checked buttons, but on the click event, the active class is not yet set. That means, when I first click a button, the output is:

>>> 0
>>> false

And the next time I click the same button (i.e., uncheck it), the output is:

>>> 1
>>> true

That means the active class is being set after the event.

How can I get the real state of the button during the click event?

score 4 · Answer 1 · edited May 23 '17 at 12:22

I've been having issues with the click event and the timing of the active class too!

Furthering davidkonrad's answer and using this post I came up with the following to avoid having to modify bootstrap source but a bit more lightweight than a full override.

var _old_toggle = $.fn.button.prototype.constructor.Constructor.prototype.toggle;

$.fn.button.prototype.constructor.Constructor.prototype.toggle = function () {
    _old_toggle.apply(this);

    if (this.$element.hasClass('active')) {
        this.$element.trigger('active')
    }
}

score 1 · Accepted Answer · edited May 23 '17 at 12:30

If you desperately want an event each time the class active is added to a button, you could modify the bootstrap.js. active is set/unset in a small function Button.prototype.toggle triggered by click, line 1362-1370 :

Button.prototype.toggle = function () {
    var $parent = this.$element.closest('[data-toggle="buttons-radio"]')

    $parent && $parent
      .find('.active')
      .removeClass('active')

    this.$element.toggleClass('active')
  }

change this to

Button.prototype.toggle = function () {
    var $parent = this.$element.closest('[data-toggle="buttons-radio"]')

    $parent && $parent
      .find('.active')
      .removeClass('active')

    this.$element.toggleClass('active')

    if (this.$element.hasClass('active')) {
        this.$element.trigger('active')
    }
  }

now you have an event you can bind to .myclass

$(".myclass").on('active', function() {
  console.log($(".myclass.active").length);
  console.log($(this).hasClass("active"));
});

OR, if you think the above is too dirty - you can extend / modify the Button.prototype (adding methods, options etc) by following the skeleton described here How to Extend Twitter Bootstrap Plugin

score 0 · Answer 3 · answered Nov 05 '12 at 17:35

You have deduced correctly. The click event has not updated the active class yet, so when you are searching for them, it does not return. There is no event that is triggered for class change.

However, what you can do is add a setTimout of say, 100ms, enough time to allow the click event to have triggered. Note, you may need to adjust the delay to allow the event propagation.

score 0 · Answer 4 · answered Jun 26 '13 at 14:02

0

I used jQuery's data management to store an active state, toggling it on button clicks. Not very nice either but it's something.

answered Jun 26 '13 at 14:02

Patrick Bergner

623
8
23

Twitter Bootstrap checkbox-button value changed after click event

4 Answers4