Why UrlValidator do not work for some of my Urls?

Question

String[] schemes = {"http","https"};
UrlValidator urlValidator = new UrlValidator(schemes, UrlValidator.ALLOW_ALL_SCHEMES);
System.out.println(urlValidator.isValid(myUrl));

the following URL says, invalid. Any one know why is that. the localnet is a localnetwork. But this works for any other public network (it seems).

http://aunt.localnet/songs/barnbeat.ogg

`UrlValidator` presumably from apache commons? Have a look at the code and figure it out. Might be because it doesn't recognise localnet as a tld. — Qwerky, Nov 08 '12 at 12:17

score 5 · Answer 1 · answered Apr 17 '13 at 18:30

5

The class you're using is deprecated. The replacement is

org.apache.commons.validator.routines.UrlValidator

Which is more flexible. You can pass the flag ALLOW_LOCAL_URLS to the constructor which would allow most addresses like the one you are using. In our case, we had authentication data preceeding the address, so we had to use the even-more-flexible UrlValidator(RegexValidator authorityValidator, long options) constructor.

answered Apr 17 '13 at 18:30

Quartz

1,731
1
14
17

6

ALLOW_LOCAL_URLS is not enough to get validation path for such host name. – Yves Martin Sep 19 '13 at 14:17
I had to rebuild authority regular expression to skip domain segment validation code: `new UrlValidator(new RegexValidator("^([\\p{Alnum}\\-\\.]*)(:\\d*)?(.*)?"))` – Yves Martin Sep 19 '13 at 14:23
Thanks Yves using RegexValidator worked for me too, otherwise `http://fooserver.local/` isn't considered valid. I guess this regex would have to be changed to also support IPV6 addresses. I just asked on their mailing list http://markmail.org/thread/3ozz3azcnlpt4cxu if their list of LOCAL_TLDS should be expanded. – jamshid Nov 11 '13 at 00:55
@YvesMartin your regex seems to match everything in the third group, and that group seems to match everything. – froginvasion Aug 30 '16 at 13:57

score 4 · Accepted Answer · answered Nov 08 '12 at 12:35

4

As I thought, its failing on the top level;

String topLevel = domainSegment[segmentCount - 1];
if (topLevel.length() < 2 || topLevel.length() > 4) {
  return false;
}

your top level is localnet.

answered Nov 08 '12 at 12:35

Qwerky

18,217
6
44
80

This was true for older versions of commons-validator, but is not true if you use org.apache.commons.validator.routines.UrlValidator from the current version (1.6) – Steve Bosman Apr 09 '19 at 11:10

score 1 · Answer 3 · answered Aug 17 '15 at 19:20

1

This is fixed in the 1.4.1 release of the Apache Validator:

https://issues.apache.org/jira/browse/VALIDATOR-342 https://issues.apache.org/jira/browse/VALIDATOR/fixforversion/12320156

A simple upgrade to the latest version of the validator should fix things nicely.

answered Aug 17 '15 at 19:20

drchuck

4,415
3
27
30

1

The VALIDATOR-342 bug is an other problem. Is because of the .rocks TLD. "The .rocks TLD is quite recent and is not included in the list used by the Domain validator." – Jose Rego Sep 01 '15 at 10:30
Thanks @drchuck! It helped in my case. I was tricked by Google. They're showing commons-validator 1.4.0 as the first result while current version is 1.5.1! – Lukasz Wiktor Nov 30 '16 at 09:57

score 0 · Answer 4 · answered Nov 08 '12 at 12:23

0

check line 2 it should be

new UrlValidator(schemes);

if you want to allow 2 slashes and disallow fragments

new UrlValidator(schemes, ALLOW_2_SLASHES + NO_FRAGMENTS);

answered Nov 08 '12 at 12:23

Mohamed Jameel

602
5
21

score 0 · Answer 5 · answered Nov 08 '12 at 12:24

0

Here is the source code for isValid(String) method:

You can check the result at each step by manual call to understand where it fails.

answered Nov 08 '12 at 12:24

Nikolay Kuznetsov

9,467
12
55
101

oops, those methods are protected. But the docs says that isValid is deprecated: http://commons.apache.org/validator/apidocs/org/apache/commons/validator/UrlValidator.html#isValid(java.lang.String) – Nikolay Kuznetsov Nov 08 '12 at 12:28
i use "validator.routines.UrlValidaor" is not deprecated – dinesh707 Nov 08 '12 at 12:34

score 0 · Answer 6 · edited Nov 17 '21 at 07:47

0

The library method fails on this URL:

  "http://en.wikipedia.org/wiki/3,2,1..._Frankie_Go_Boom"

Which is perfectly legal (and existing) URL.

I found by trial and error that the below code is more accurate:

public static boolean isValidURL(String url)
{
    URL u = null;
    try
    {
        u = new URL(url);
    }
    catch (MalformedURLException e)
    {
        return false;
    }

    try
    {
        u.toURI();
    }
    catch (URISyntaxException e)
    {  
        return false;  
    }  

    return true;  
}

edited Nov 17 '21 at 07:47

Phil

401
8
18

answered Sep 30 '13 at 11:30

zmashiah

153
1
1
9

Note that this only works if your URL is already encoded! URI only accepts URLs with encoded query parameters, else it will throw an exception! – froginvasion Aug 30 '16 at 13:28

score 0 · Answer 7 · answered Oct 23 '14 at 17:39

0

You can use the following:

UrlValidator urlValidator = new UrlValidator(schemes, new RegexValidator("^((?!-)[A-Za-z0-9-]{1,63}(?<!-)\\.)+[A-Za-z]{2,6}$"), 0L);

answered Oct 23 '14 at 17:39

Armando Carrasco

19
3

2

This does not allow ports to be given whatsoever, and the last part can only be maximum 6 characters as defined in your Regex `{2,6}` – froginvasion Aug 30 '16 at 13:29

Why UrlValidator do not work for some of my Urls?

7 Answers7