Multiple actions were found that match the request Web API?

Question

I am using web API and i am new in this. I am stuck in a routing problem. I have a controller with following actions :

    // GET api/Ceremony
    public IEnumerable<Ceremony> GetCeremonies()
    {
        return db.Ceremonies.AsEnumerable();
    }

    // GET api/Ceremony/5
    public Ceremony GetCeremony(int id)
    {
        Ceremony ceremony = db.Ceremonies.Find(id);
        return ceremony;
    }

    public IEnumerable<Ceremony> GetFilteredCeremonies(Search filter)
    {
        return filter.Ceremonies();
    }

The problem occure when i added the action GetFilteredCeremonies to my controller. After adding this when i make an ajax call to GetCeremonies action then it return an Exception with following message :

"Message":"An error has occurred.","ExceptionMessage":"Multiple actions were 
 found that match the request

FYI: The parameter Search is the Model class which contains properties and a function name Ceremonies.

EDIT

Route:

config.Routes.MapHttpRoute(
                name: "DefaultApi",
                routeTemplate: "api/{controller}/{id}",
                defaults: new { id = RouteParameter.Optional }
            );

I think this is the same issue as http://stackoverflow.com/questions/9499794/single-controller-with-multiple-get-methods-in-asp-net-web-api — Davin Tryon, Nov 08 '12 at 14:40
Have two methods in controller with name GetCeremony() try to resolve them as they both pointed to same route — Saurabh Chauhan, Feb 08 '17 at 10:29

score 22 · Answer 1 · edited Jan 22 '15 at 22:12

22

If you're not requirement bound to use REST services that use api/{controller}/{id} route and attempt to resolve action based on method GET/POST/DELETE/PUT, you can modify your route to classic MVC route to api/{controller}/{action}/{id} and it will solve your problems.

edited Jan 22 '15 at 22:12

Amirhossein Mehrvarzi

18,024
7
45
70

answered Nov 10 '12 at 06:27

Admir Tuzović

10,997
7
35
71

A short and sweet way. – himanshupareek66 Jul 01 '14 at 07:18

score 8 · Answer 2 · edited Mar 20 '13 at 18:30

The problem here is your 2 Get methods will resolve to api/Ceremony and MVC does not allow parameter overloading. A quick workaround (not necessarily the preferred approach) for this sort of problem is to make your id parameter nullable e.g.

// GET api/Ceremony
public IEnumerable<Ceremony> GetCeremonies(int? id)
{
    if (id.HasValue)
    {
        Ceremony ceremony = db.Ceremonies.Find(id);
        return ceremony;
    }
    else
    {
        return db.Ceremonies.AsEnumerable();
    }
}

However, you would then be returning a list of ceremonies when with 1 item when your trying to query for a single ceremony - if you could live with that then it may be the solution for you.

The recommended solution is to map your paths appropriately to the correct actions e.g.

context.Routes.MapHttpRoute(
    name: "GetAllCeremonies",
    routeTemplate: "api/{controller}",
    defaults: new { action = "GetCeremonies" }
);

context.Routes.MapHttpRoute(
    name: "GetSingleCeremony",
    routeTemplate: "api/{controller}/{id}",
    defaults: new { action = "GetCeremony", id = UrlParameter.Optional }
);

I think there's a bug there, your routers should have different names — Alex, Feb 02 '13 at 16:28

score 6 · Answer 3 · answered Nov 11 '15 at 01:18

Luckily nowadays with WEB API2 you can use Attribute Routing. Microsoft has gone open source on a big scale and then a wizard named Tim McCall contributed it from the community. So since somewhere end 2013, early 2014 you can add attributes like [Route("myroute")] on your WEB API methods. See below code example.

Still - as I just found out - you have to make sure to use System.Web.Http.Route and NOT System.Web.Mvc.Route. Otherwise you'll still get the error message Multiple actions were found that match the request.

using System.Web.Http;
...

[Route("getceremonies")]
[HttpGet]
// GET api/Ceremony
public IEnumerable<Ceremony> GetCeremonies()
{
    return db.Ceremonies.AsEnumerable();
}

[Route("getceremony")]
[HttpGet]
// GET api/Ceremony/5
public Ceremony GetCeremony(int id)
{
    Ceremony ceremony = db.Ceremonies.Find(id);
    return ceremony;
}

[Route("getfilteredceremonies")]
[HttpGet]
public IEnumerable<Ceremony> GetFilteredCeremonies(Search filter)
{
    return filter.Ceremonies();
}

score 3 · Answer 4 · answered Mar 04 '14 at 03:00

Here is my controller:

public class PhoneFeaturesController : ApiController
{
    public List<PhoneFeature> GetbyPhoneId(int id)
    {
        var repository = new PhoneFeatureRepository();
        return repository.GetFeaturesByPhoneId(id);
    }

    public PhoneFeature GetByFeatureId(int id)
    {
        var repository = new PhoneFeatureRepository();
        return repository.GetFeaturesById(id);
    }        
}

Here is my api routing:

        config.Routes.MapHttpRoute(
            name: "ApiWithId", 
            routeTemplate: "Api/{controller}/{id}",
            defaults: new { id = RouteParameter.Optional },
            constraints: new { id = @"^[0-9]+$" });

        config.Routes.MapHttpRoute(
            name: "ApiWithAction", 
            routeTemplate: "api/{controller}/{action}/{name}",
            defaults: null,
            constraints: new { name = @"^[a-z]+$" });

        config.Routes.MapHttpRoute(
            name: "ApiByAction",
            routeTemplate: "api/{controller}/{action}/{id}",
            defaults: new { action = "Get" },
            constraints: new { id = @"^[0-9]+$" });

        config.Routes.MapHttpRoute(
            name: "DefaultApi",
            routeTemplate: "api/{controller}/{id}",
            defaults: new { id = RouteParameter.Optional }
        );

I tested it like this:

/api/PhoneFeatures//api/PhoneFeatures/GetFeatureById/101

/api/PhoneFeatures/GetByFeatureId/12

It works smooth in every condition :)

score 2 · Answer 5 · answered Mar 23 '18 at 19:06

I found another fix that doesn't require moving methods out of the controller or changing the route mapping config. Just add the [NonAction] attribute to the method you want to exclude:

[NonAction]
public IEnumerable<Ceremony> GetFilteredCeremonies(Search filter)

score 0 · Answer 6 · answered Jul 10 '13 at 18:17

Please check you have two methods which has the different name and same parameters.

If so please delete any of the method and try.

This error was raised because there are two methods which are looking for same parameters. try to delete any one of them and try...

Deepak Raj · Answer 7 · 2014-04-29T07:45:53.560

0

I hope you are doing HttpGet while you invoke GetFilteredCeremonies(Search filter)

In that case, you cannot pass complex object in GET request like Search that you are passing.

If for some reason, you definitely want to get complex types in your get request, there are some work around. You may need to write a custom model binder and then set the attribute. please refer this article.

edited Apr 29 '14 at 07:45

answered Mar 04 '14 at 05:21

Deepak Raj

730
2
9
26

complex types can be passed, [FromUri] attribute should be used – Daniel Leiszen Apr 28 '14 at 21:41
well, for passing complex objects, you will need to use some type of "Custom Model Binder" which is not provided by ASP.NET Web API by default. – Deepak Raj Apr 29 '14 at 07:40
ok..i will add this also in my answer to be complete..thanks for bringing this out.. – Deepak Raj Apr 29 '14 at 07:43

score 0 · Answer 8 · answered Apr 07 '17 at 15:42

Edit Your WebApiConfig.cs in App_Start folder on the root of project and add {action} to routeTemplate parameter in MapHttpRoute Method like below :

 config.Routes.MapHttpRoute(
            name: "DefaultApi",
            routeTemplate: "api/{controller}/{action}/{id}",
            defaults: new { id = RouteParameter.Optional }
        );

Multiple actions were found that match the request Web API?

8 Answers8

Linked

Related