my shuffle string[] not working?

Question

I tried to write a shuffle string array algo but I get a null reference error.. I can't figure out why..

public static string[] arrRandomized;
public static string[] ShuffleWords(string[] Words)
{
    Random generator = new Random();
    for (int i=0;i < Words.Length; i++) {
        int pos = generator.Next(Words.Length);
        Console.WriteLine(Words[pos]); // I SEE RANDOM ITEM
        Console.Read(); // NULL REFERENCE ERROR AFTER THIS
        if (Words[pos] != null)
        {
            arrRandomized[i] = Words[pos];
            //remove item at pos so I get no duplicates
            Words[pos] = null;
        }
    }

I don't want to use ArrayList, i have my reasons but thats off topic I just want to know how come this isn't working :/ thanks

Changing a collection (or array) while iterating over it is inadvisable. — Oded, Nov 10 '12 at 18:23
@Vaibhav Desai is just used to pause it, removing that makes no difference.. — ace007, Nov 10 '12 at 18:35

score 3 · Answer 1 · answered Nov 10 '12 at 18:38

3

I think you should initialize arrRandomized:

arrRandomized = new string[Words.Length];

answered Nov 10 '12 at 18:38

Paolo Tedesco

55,237
33
144
193

score 0 · Answer 2 · answered Nov 10 '12 at 18:40

Your arrRandomized is never intialized. I would also recommend that you return an array rather then use a static reference because the subsequent calls to the method will change all references to the arrRandomized.

public static string[] ShuffleWords(string[] Words)
{    
    string[] arrRandomized = new string[Words.Length];
    Random generator = new Random();
    for (int i=0;i < Words.Length; i++) 
    {
        int pos = generator.Next(Words.Length);
        Console.WriteLine(Words[pos]); // I SEE RANDOM ITEM
        Console.Read(); // NULL REFERENCE ERROR AFTER THIS
        if (Words[pos] != null)
        {
            arrRandomized[i] = Words[pos];
            //remove item at pos so I get no duplicates
            Words[pos] = null;
        }
    }
    return arrRandomized;
}

got ridd of the error, but now the return array only has 2 items instead of 4.. the other 2 are there but empty :/ — ace007, Nov 10 '12 at 18:52

my shuffle string[] not working?

2 Answers2