My string is output as a bunch of nonsense

Question

#include <stdio.h>
#include <string.h>

/* Function prototypes */
void wordLength ( char *word );
void wordConcat ( char *wordC1, char *wordC2);


int main (void)
{

    int choice;
    char word [20];
    char wordC1 [20];
    char wordC2 [20];


    printf( "Choose a function by enterting the corresponding number: \n"
        "1) Determine if words are identical\n"
        "2) Count number of words in sentence provided\n"
        "3) Enter two strings to be strung together\n"
        "4) Quit program\n" );
    scanf( "%d", &choice );
    flushall();

    while (choice >= 1 && choice < 4) 

{

        /* if statements for appropriate user prompt and calls function */
        if (choice == 1) 
        {
            /* gather user input */
        printf( "\nYou have chosen to determine word length.\n"
                "Please enter the word:\t");
            gets( word );

            /* call function to output string as well as the string length */
            wordLength( word );


        }

        else if (choice == 2)
        {
            printf( "\nYou have chosen to concatenate 2 words with a % symbol in between them.\n"
                "Please enter word 1:\t");

            gets( wordC1 );

            printf("Please enter word 2:\t");

            gets( wordC2 );                     

            /* call function to output string as well as the string length */
            wordLength( word );
    }
}
}
void wordLength( char *word )

{
    int length;

    printf( "\nThe string entered is:  %s\n\n", word);

    length = strlen (word);

    printf("The string length is: %d\n", length);

    return;
}

void wordConcat(char *wordC1, char *wordC2)

{
    char symbol = "\ 25";
    char result;
    printf( "\nThe first word entered is:  %s\n", wordC1);
    printf( "\nThe second word entered is:  %s\n", wordC2);

    result = strcat( wordC1, symbol, wordC2);

    printf("Output: %s\n", result);

    return;
}

Whenever I enter 2 words for the wordConcat function of my program the string output is a bunch of nonsense :( All of my pointers appear to be pointing at the right places. What am I doing incorrectly?

you just asked this question: http://stackoverflow.com/questions/13336808/how-do-you-concatonate-strings-in-c — Mitch Wheat, Nov 12 '12 at 00:35
Yes :( but it isn't working everything appears correct but the output is "╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠╠☻" — user1724390, Nov 12 '12 at 00:37
What is this supposed to do: `result = strcat( wordC1, symbol, wordC2);` — Hot Licks, Nov 12 '12 at 00:41

score 1 · Answer 1 · answered Nov 12 '12 at 00:37

1

choice == 2 code is calling wordLength() instead of wordConcat(), so the word variable it passes in is not set.

answered Nov 12 '12 at 00:37

John3136

28,809
4
51
69

Wow, I need to stop copy and pasting... Thanks for fixing my idiotic mistake... And now I get an exception – user1724390 Nov 12 '12 at 00:38
Never mind I fixed my own problem for once! Thanks! – user1724390 Nov 12 '12 at 00:42

My string is output as a bunch of nonsense

1 Answers1