Adding a statement to an if-else block broke my code

Question

This works (It prints some text to the screen):

$(document).ready(function() {

var uspTot = 1
var keyTot = 5

    $('.field .button').click(function(){
    var theSibling = $(this).siblings('div').attr('id');
    if (theSibling == 'usp'){
       $(this).before('the string is usp')
       uspTot++ 
    } else if (theSibling == 'keywords')(
       $(this).before('the string is keywords') 
    )
});

However this doesn't do anything:

$(document).ready(function() {

var uspTot = 1
var keyTot = 5

    $('.field .button').click(function(){
    var theSibling = $(this).siblings('div').attr('id');
    if (theSibling == 'usp'){
       $(this).before('the string is usp')
       uspTot++ 
    } else if (theSibling == 'keywords')(
       $(this).before('the string is keywords')
       keyTot++
    )
});

The only difference between the two is this bit of code:

keyTot++

I can't understand why this is completely breaking my basic script so I'm hoping someone here can point and say "Oh that's because you've forgotten to XXXX, you daft thing" - Or words to that effect.

What if you use semicolons (as IMO you should generally do in JS)? — Dave Newton, Nov 13 '12 at 16:32
@DaveNewton That's completely stylistic and nothing to do with the problem. — James M, Nov 13 '12 at 16:33
@JamesMcLaughlin I strongly disagree with semicolons being "completely stylistic" — Adriano Carneiro, Nov 13 '12 at 16:34
The problem is a simple typo. Separately: It's best not to rely on the horror that is [automatic semicolon insertion](http://ecma-international.org/ecma-262/5.1/#sec-7.9). Eventually, it ***will*** bite you. — T.J. Crowder, Nov 13 '12 at 16:37
@Adrian, while you may disagree, this is absolutely no NEED to use semicolons in javascript. (I do use them by the way, maybe because my primary language is C#?) — gdoron, Nov 13 '12 at 16:37
@gdoron: Sure there is. Maintainability is a need. But I don't want to swamp the question with off-topic comments... :-) — T.J. Crowder, Nov 13 '12 at 16:37
@gdoron Look here for some ambiguous code due to lack of semicolons: http://stackoverflow.com/a/1169596/570191 — Adriano Carneiro, Nov 13 '12 at 16:39
@T.J.Crowder. See my answer and [this little demo](http://jsfiddle.net/pujk5/) ... :) — gdoron, Nov 13 '12 at 16:39
@gdoron: I should have looked more closely, stray parens are frequently not actually syntactically wrong. :-) Nice one. — T.J. Crowder, Nov 13 '12 at 16:41
@gdoron Since you use them, you won't have been bitten by *not* using them. Relying on getting the ambiguous cases right is rarely the right answer, and leads to inconsistent coding style. While it wasn't the issue in this case, why risk it *being* the issue? — Dave Newton, Nov 13 '12 at 16:45

score 2 · Accepted Answer · answered Nov 13 '12 at 16:33

You got typo with the braces:

} else if (theSibling == 'keywords')(
       $(this).before('the string is keywords')
       keyTot++
    )

Should be:

} else if (theSibling == 'keywords'){
       $(this).before('the string is keywords')
       keyTot++
    }

The curly braces are mandatory for more than one command, this is why you're not getting the error.

When you used regular braces the code was treated as:

} else if (theSibling == 'keywords')
    ($(this).before('the string is keywords'))

Which is valid, but useless...

Oh my gosh - That's it! I can't believe I missed that. Thank you so much :) — Username_null, Nov 13 '12 at 16:39

score 1 · Answer 2 · answered Nov 13 '12 at 16:32

1

else if (theSibling == 'keywords')(
        $(this).before('the string is keywords')
        keyTot++
)

You wanted curly braces:

else if (theSibling == 'keywords'){
        $(this).before('the string is keywords')
        keyTot++
}

answered Nov 13 '12 at 16:32

James M

18,506
3
48
56

1

Thanks, I feel a bit of a numpty now :) – Username_null Nov 13 '12 at 16:39

score 0 · Answer 3 · answered Nov 13 '12 at 17:06

0

You are using regular brace where you should be using curly braces. Proper sintax for if and else is if(){} else if () {} So your both blocks are wrong.

answered Nov 13 '12 at 17:06

tonino.j

3,837
28
27

score -1 · Answer 4 · answered Nov 13 '12 at 16:34

-1

You are missing semicolons after the $this.before(); statements.

answered Nov 13 '12 at 16:34

Coby

1,528
9
8

@JamesMcLaughlin. For some reason lots of people think so. :( – gdoron Nov 13 '12 at 16:44

Adding a statement to an if-else block broke my code

4 Answers4