Using 'stringWithString:' with a literal is redundant

Question

i used this code in reachability class that is in ios6

   switch (status) {
        case kNotReachable:
            statusString = [NSString stringWithString: @"Not Reachable"];
            break;
        case kReachableViaWWAN:
            statusString = [NSString stringWithString: @"Reachable via WWAN"];
            break;
        case kReachableViaWiFi:
            statusString = [NSString stringWithString: @"Reachable via WiFi"];
            break;
    }

but the following error is occurred "Using 'stringWithString:' with a literal is redundant"

Why not just use the literals by themselves? Rather than using stringWithString — John, Nov 14 '12 at 06:08

score 9 · Answer 1 · edited May 23 '17 at 10:24

9

The warning is saying that you could instead easily do like this:

statusString = @"Not Reachable";

The explanation is provided in the post Obj-C: [NSString stringWithString:@"string"] vs. @"string"

edited May 23 '17 at 10:24

Community

1
1

answered Nov 14 '12 at 06:11

score 4 · Answer 2 · answered Dec 20 '12 at 06:58

4

Instead of using

statusString = [NSString stringWithString: @"Not Reachable"];

please write your code like below:

statusString = @"Content-Type: Not Reachable/unknown\r\n\r\n";

warning will be removed.

answered Dec 20 '12 at 06:58

Banshi

1,335
2
13
21

score 2 · Answer 3 · answered Nov 14 '12 at 06:11

2

You resolve these 'warnings' simply by declaring your strings like so:

statusString = @"";

instead of

statusString = [NSString stringWithString:@""];

answered Nov 14 '12 at 06:11

Jens Bergvall

1,617
2
24
54

score 0 · Answer 4 · answered Dec 20 '12 at 07:05

0

I think this is a type of compiler optimization. Actually you need to assign a string to variable. You can do it directly as myString = @"" no need to call a method and it will use additional processing time.

answered Dec 20 '12 at 07:05

rakeshNS

4,227
4
28
42

Using 'stringWithString:' with a literal is redundant

4 Answers4

Linked

Related