Get value of item on OnItemClick Listview

Question

I try to get the value of a selected Item within a custom adapter on a listview. I try this with following code:

public void onItemClick(AdapterView<?> parent, View v,
                        int position, long id) {

                    View curr = parent.getChildAt((int) id);
                    TextView c = (TextView)curr.findViewById(R.id.tvPopUpItem);
                    String playerChanged = c.getText().toString();

                    Toast.makeText(Settings.this,playerChanged, Toast.LENGTH_SHORT).show();

                }

At the beginning, if I click, the values are good, but once I scrolled and I click on another Item, I get the wrong value of that clicked item... Any idea what is causing this?

score 49 · Accepted Answer · answered Nov 15 '12 at 20:32

49

The parameter v is the current row. so use:

public void onItemClick(AdapterView<?> parent, View v, int position, long id) {
    TextView c = (TextView) v.findViewById(R.id.tvPopUpItem);
    String playerChanged = c.getText().toString();

    Toast.makeText(Settings.this,playerChanged, Toast.LENGTH_SHORT).show();
}

(Or you could use getChildAt(position) but this would be slower.)

Understand you might be able to simplify this more depending on your layout.

answered Nov 15 '12 at 20:32

Sam

86,580
20
181
179

Thanks, this works! Do you have any idea why the getChildAt position didn't work? I also tried this, but this gave me errors as well.. – Matthias Vanb Nov 15 '12 at 20:34
1

Depending on your adapter `id` might refer to a completely different index. For example CursorAdapters return the table's primary key in `id`. `position` on the other hand should always refer to the row count. – Sam Nov 15 '12 at 20:36

score 0 · Answer 2 · answered Jan 03 '15 at 09:08

0

Just Small Change is Required

TextView c = (TextView) v.findViewById(R.id.tvPopUpItem);

Since you are using custom view you need to pass the View argument in your OnItemClickListener then you need to use that value to get the Details of TextViews present in that

answered Jan 03 '15 at 09:08

Mahesh G

1,226
4
30
57

1

Next time make a comment, do not post an additional answer. – sparticvs Apr 28 '15 at 19:50

score 0 · Answer 3 · edited May 24 '17 at 11:34

listView.setOnItemClickListener(new AdapterView.OnItemClickListener() {
            @Override
            public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
                Intent i=new Intent(ListOfAstrologers.this,AstroProForUser.class);
                i.putExtra("hello",adapter.getItem(position).getUsername() );
                startActivity(i);
            }
        });

Here username is a string field declared in a class and you must over ride getItem() method in adapter class to get the details of inflated row when you click.

score 0 · Answer 4 · answered Sep 17 '22 at 04:18

I dont have much experience but I think if you want to pass a variable from an OnClick (which is an anonimous class) to the outside of the onClick and to the other activity, you want to pass it via Intent intent.putExtra... (it's quite easy) Otherwise you might end up using "public static" variable, which might be a memory leak...

Get value of item on OnItemClick Listview

4 Answers4

Linked