Make enyo.canvas fit

Question

I have this fiddle: http://jsfiddle.net/y9mhE/3/

Now I want to make the canvas control fit the parent div. Since it inherits enyo.control I should be able to use the 'fit' property, but that does not seem to work.

is this a bug, or am I missing something

( http://enyojs.com/api/#enyo.Canvas )

The canvas control has a width and height property (default 500), maybe this overrides the fit property?

I must include code here, so:

enyo.kind({
    name: "App",
    kind: enyo.Control,
    fit: true,
    components: [
    {
        kind:enyo.Canvas,
        name:"canvas",
        fit:true

    }
    ]
});

for now, I have fixed it like this http://jsfiddle.net/y9mhE/6/ (but it feels dirty) — Pieter Willaert, Nov 28 '12 at 14:45

inta · Accepted Answer · 2012-11-29T07:40:49.767

1

The fit property does not belong to the enyo.Control kind, it can only be used inside a fittable kind. So change your apps kind to "FittableColumns" or "FittableRows" (or set layoutKind of "FittableColumnsLayout" or "FittableRowsLayout"), like this:

enyo.kind({
    name: 'App',
    kind: 'FittableColumns',
    /* or:
    kind: enyo.Control,
    layoutKind: 'FittableColumnsLayout', */
    components: [
        {
            name: 'canvas',
            kind: enyo.Canvas,
            fit: true // works now because of parents fittable layout
        }
    ]
});

I updated your fiddle: http://jsfiddle.net/y9mhE/7/

edited Nov 29 '12 at 07:40

answered Nov 29 '12 at 07:26

inta

570
2
11
16

Thanks for the explanation. I think this should be documented in the enyo.Control class, since 'fit' is documented as a property there – Pieter Willaert Nov 29 '12 at 10:58
Yes that should be pointed out in the API docs. You could file a bug at the [Enyo bugtracker](https://enyojs.atlassian.net/secure/Dashboard.jspa) or write a comment at the [forums](http://forums.enyojs.com/). – inta Nov 29 '12 at 19:19
1

Thanks for the comment. I'm updating the inline docs for enyo.Control based on this. – Ben Combee Dec 13 '12 at 09:07

Make enyo.canvas fit

1 Answers1