When releasing the objects in the custom cell class app crashes

Question

I have a problem with my app crashing when my custom TableViewCell gets released. The code that i tried is given below .It Didn't go for the names of the variouble.

The Cell gets initialized like the following in cellForRowAtIndexPath.

static NSString *CellIdentifier1 = @"CellIdentifier";
    static NSString *CellIdentifier2 = @"Cell";
     if (indexPath.section == 0 && indexPath.row==0)
    { 
         CustomCell *cell = (CustomCell *)[tableView dequeueReusableCellWithIdentifier:CellIdentifier1];
       if (cell == nil)
        {
            cell = [[[CustomCell alloc] initWithStyle:UITableViewCellStyleSubtitle reuseIdentifier:CellIdentifier1] autorelease];
            cell.backgroundView = [ [[UIImageView alloc] initWithImage:[ [UIImage imageNamed:@"dfdfdf.png"] stretchableImageWithLeftCapWidth:0.0 topCapHeight:5.0] ]autorelease];
        }
   [cell.fgfbutton addTarget:self action:@selector(callAction:) forControlEvents:UIControlEventTouchUpInside];     
 cell.myImageView.image=[UIImage imageNamed:@"fdfdfdf.png"];
    cell.fddfdbutton.tag=indexPath.section+1;
       return cell;

    }
    else if (indexPath.section == 1 && indexPath.row==0) 
    {
        Customcellwithimage *cell = (Customcellwithimage *)[tableView dequeueReusableCellWithIdentifier:CellIdentifier2];

        if (cell == nil)
        {
            cell = [[[Customcellwithimage alloc] initWithStyle:UITableViewCellStyleSubtitle reuseIdentifier:CellIdentifier2] autorelease];
             cell.backgroundView = [ [[UIImageView alloc] initWithImage:[ [UIImage imageNamed:@"fetrtrtrt.png"] stretchableImageWithLeftCapWidth:0.0 topCapHeight:5.0] ]autorelease];
        }

         cell.selectionStyle = UITableViewCellSelectionStyleNone;

        [cell.dfdfbutton1 addTarget:self action:@selector(callAction:) forControlEvents:UIControlEventTouchUpInside]; 


        return cell;


    }

and in my custom cell class i am releasing the cell objects in the dealloc methode.and in my custom cell i am doing like this

- (id)initWithStyle:(UITableViewCellStyle)style reuseIdentifier:(NSString *)reuseIdentifier
{
    self = [super initWithStyle:style reuseIdentifier:reuseIdentifier];
    if (self) {
        nameLabel = [[UILabel alloc]init];
        [nameLabel setFont:[UIFont fontWithName:@"Helvetica-Bold" size:16]];
        nameLabel.textAlignment = UITextAlignmentLeft;
        nameLabel.textColor = [UIColor blackColor];
        nameLabel.numberOfLines = 0;

        nameLabel.backgroundColor =[UIColor clearColor];
        nameLabel.adjustsFontSizeToFitWidth = NO;

       sfdfbutton = [UIButton buttonWithType:UIButtonTypeCustom];

        [sdsdbutton setImage:[UIImage imageNamed:@"_it.png"] forState:UIControlStateNormal];
        [sdbutton setImage:[UIImage imageNamed:@"ed.png"] forState:UIControlStateSelected]; 
        sdsdbutton.selected=NO;

            myImageView = [[UIImageView alloc] init];
        bottomborder=[[UIImageView alloc] init];
        UIImage *img1 = [UIImage imageNamed:@"_bg.png"];
        [bottomborder setImage:img1];

        [self.contentView addSubview:nameLabel];

        [self.contentView addSubview:myImageView];

    }
    return self;
}
- (void)layoutSubviews {
    [super layoutSubviews];
    //CGRect contentRect = self.contentView.bounds;
    //CGFloat boundsX = contentRect.origin.x;
    CGRect frame;

    //frame= CGRectMake(0 ,0, 300, 135);
    //cellview.frame = frame;
    frame= CGRectMake(60 ,8, 220, 20);
    nameLabel.frame = frame;

    myImageView.frame = CGRectMake(10,6,40,40);
    NSLog(@"nameLabel frame: %@", NSStringFromCGRect(myImageView.frame));
    nhghbutton.frame =CGRectMake(4,12 + frame.origin.y + frame.size.height, 82, 35);

}
- (void)setSelected:(BOOL)selected animated:(BOOL)animated
{
    [super setSelected:selected animated:animated];


}
- (void)dealloc {

   [bottomborder release];
   [myImageView release];
   [label release];
   [super dealloc];
}

label,button,are there. all are instance varioubles having set as property? — angry_developer, Dec 03 '12 at 05:36
http://stackoverflow.com/questions/7402171/calayer-release-message-sent-to-deallocated-instance.I found this article be very help full.. — angry_developer, Dec 03 '12 at 05:39

score 1 · Accepted Answer · answered Dec 01 '12 at 11:19

1

You are probably overreleasing your UIButton: sfdfbutton if you do [sfdfbutton release] in dealloc of your table view cell. That's because it is autoreleased object.

If this is not the problem, try running application with Instruments.

answered Dec 01 '12 at 11:19

Piotr Wach

913
2
9
22

label,button,are there. all are instance varioubles having set as property? – angry_developer Dec 01 '12 at 11:21
he's right, the button is autoreleased. you get it from buttonWithType and dont retain it.. cleanest IMO would be to retain it there – Daij-Djan Dec 01 '12 at 11:36
there is lots of code missing btw... you use all kinds of buttons and sdsdbutton is never used for anything for example... – Daij-Djan Dec 01 '12 at 11:44

score -1 · Answer 2 · answered Dec 01 '12 at 11:21

-1

To solve these kinds of issues, start your app with NSZombieEnabled set to YES (Product > Edit Scheme... and add this to Environment Variables).

This will point out exactly which variable gets overreleased. You can also perform a static analysis of your program by typing Cmd+Shift+B.

answered Dec 01 '12 at 11:21

Krumelur

31,081
7
77
119

analysis and instrument showing no leaks at all.when i comment on the release at dealloc everything works fine – angry_developer Dec 01 '12 at 11:24

When releasing the objects in the custom cell class app crashes

2 Answers2