Whats wrong here, why is innerHTML not working?

Question

I wanted to ask why innerHTML is not working in the following code:

document.getElementById('text').innerHTML = localStorage["mytext"];

The element with the id text is a div element. localStorage is giving me the right String if I use it with alert, what could the error be?

Hard to tell with so few elements. Can you make a fiddle demonstrating the problem ? — Denys Séguret, Dec 03 '12 at 20:54
"Not working" is not helpful to try and diagnose the problem. Are you sure `getElementById` is matching an element? — Matt, Dec 03 '12 at 20:55
Are you rying to place text inside a Textbox? if so set the value, dont use innerHTML.. Thats about the only way I can see this failing assuming the element exists an the value to be placed is not null — Sajjan Sarkar, Dec 03 '12 at 20:55
@SajjanSarkar *The element with the id text is a **div** element* — Zoltan Toth, Dec 03 '12 at 20:56
Please make a sample at jsfiddle or jsbin so we can see a full, working example. Your JS could be included BEFORE the div is in the DOM, or there could be a JS error, or.... just too many possible issues imho. — Eli Gassert, Dec 03 '12 at 20:57
@SaschaMayr: What kind of jsfiddle is that? The code is working. `localStorage["mytext"]` hasn't even been defined. — Matt, Dec 03 '12 at 20:58
@SaschaMayr Please read the instructions for jsfiddle before posting it... You're not supposed to put any tag of a greater or equal level than — Jeff, Dec 03 '12 at 20:59
i replaced the localstorage thing with "test" and it works.. ur array has no value.. — Sajjan Sarkar, Dec 03 '12 at 21:00
i think jsfiddle executes Javascript on document load, so the problem (explained in my answer) will not occur — lostsource, Dec 03 '12 at 21:01
@lostsource It does when the "onload" option is set, as it is in this case. — Jeff, Dec 03 '12 at 21:01
Yes, i think the problem somewhere else..maybe DIV not yet added to DOM when the script executes.. — Sajjan Sarkar, Dec 03 '12 at 21:04

lostsource · Accepted Answer · 2012-12-03T21:02:46.630

1

Make sure the div exists before trying to reference it,

window.addEventListener("load",function() {
    document.getElementById('text').innerHTML = localStorage.getItem("mytext");
},false);

That will wait for the document to load before doing any modifications

edited Dec 03 '12 at 21:02

answered Dec 03 '12 at 20:56

lostsource

21,070
8
66
88

+1, you're probs right judging from the fiddle. You should change it to use `getItem` instead of accessing it via brackets, though. – Snuffleupagus Dec 03 '12 at 21:02

score 0 · Answer 2 · edited May 23 '17 at 11:48

0

Can you check if the localStorage["text"] really returns a string? Maybe this link might help you to check the if it's really a string.

https://stackoverflow.com/a/9729103/1873758

edited May 23 '17 at 11:48

Community

1
1

answered Dec 03 '12 at 21:23

ipinak

5,739
3
23
41

Whats wrong here, why is innerHTML not working?

2 Answers2

Linked