Substring not working on childNodes[0].nodeValue

Question

I'm trying to extract a text from td as discussed here Replacing a part of text inside a td

$('.my-table tr').each(function() {

     var contact = $(this).find('td').eq(1)[0].childNodes[0].nodeValue;
     $(this).find('td').eq(1).contents()[0].data = contact.substring(0,10);
});

But contact.substring(0,10); doesn't seem to work and it just shows empty.

How can i fix this?

1/ are you sure there is something in "contact" ? 2/ are you sure your find.eq.contents.data works ? — njzk2, Dec 07 '12 at 13:23
this is impossible to answer without seeing the related markup. there's too much going on here that could go wrong to guess. — jbabey, Dec 07 '12 at 13:30
What exactly is the data property on the last line doing? And why are you using eq() when you get the native element in the next statement? — adeneo, Dec 07 '12 at 13:30
This might help: http://stackoverflow.com/questions/7935689/what-is-the-difference-between-children-and-childnodes-in-javascript — karim79, Dec 07 '12 at 13:41
yes contact = $(this).find('td').eq(1)[0].childNodes[0].nodeValue; works — user1184100, Dec 07 '12 at 13:47

palaѕн · Accepted Answer · 2012-12-07T14:18:07.577

1

Try this:

$('.my-table tr').each(function() {

     var contact = $.trim($(this).find('td').eq(1)[0].childNodes[0].nodeValue);
     if(contact != '')
     {
         var value = contact.substring(0,10);
         alert(value);
         $(this).find('td').eq(1).contents()[0].data = contact.substring(0,10);
     }
});

What is the alert value you are getting?? or are you getting any alerts??

edited Dec 07 '12 at 14:18

answered Dec 07 '12 at 13:27

palaѕн

72,112
17
116
136

palash when i do console.log(contact) its shows me the contact but alert(value) still returns me empty.. – user1184100 Dec 07 '12 at 13:42
Business34 Owner - Manager – user1184100 Dec 07 '12 at 13:49
there is a space in start of the text. – user1184100 Dec 07 '12 at 13:49
i tried this var contact = ($(this).find('td').eq(1)[0].childNodes[0].nodeValue).trim(); seems to fix the issue probably lot of spacing at the start. – user1184100 Dec 07 '12 at 14:10

score 1 · Answer 2 · answered Dec 07 '12 at 13:56

Don't use .eq(1)[0], but just .get(0) to get plain DOM nodes. Also, don't use two different ways of obtaining the same text node, but only one and store it in a variable. Let's check what has happened:

$('.my-table tr').each(function() {

     var cell = $('td', this);
     if (!cell.length)
         return alert("Could not find a table cell");

     var el = cell.get(0);
     if (!el) alert("Could not get first element"); // Won't happen if length was >0

     if (!el.childNodes.length)
         return alert("Cell is empty!");

     var text = el.childNodes[0];
     if (cell.contents()[0] != text) alert("different firstChilds???"); // Won't happen
     if (text.nodeType != 3)
         return alert("the first child node is not a text node!");

     var contact = text.nodeValue;
     if (text.data != contact) alert("different contents???"); // Won't happen
     if (typeof contact != "string") alert("content is no string"); // Won't happen

     var newcontact = contact.substring(0,10);
     alert('"'+contact+'" was changed to "'+newcontact+'"');
     text.data = newcontact;
});

(Demo at jsfiddle.net)

score 0 · Answer 3 · answered Dec 07 '12 at 13:24

0

First of all does contact holds what you need? I mean did you console.log contact value?

If contact is ok then try something like this:

var contact = new String($(this).find('td').eq(1)[0].childNodes[0].nodeValue);

answered Dec 07 '12 at 13:24

Jevgeni Smirnov

3,787
5
33
50

Substring not working on childNodes[0].nodeValue

3 Answers3