Sanitize MySQL data in Ruby on Rails 2

Question

am reading data from a user-supplied CSV file of unknown number of rows. I iterate through the rows and rather than individually insert each row individually into the database (potentially a performance hurting large number of inserts), I concatenate the values into a single string:

insert_values += ", (#{params[:quantity]}, #{'#{params[:name]}', '#{Time.now.to_s(:db)}')"

I then build the full sql query:

sql = "INSERT INTO `my_table` (`quantity`, `name`, `created_at`) VALUES"+insert_values

Finally, I execute it:

ActiveRecord::Base.connection.execute(sql)

I want to make the data safe from malicious injection. What is the best way to do this?

score 1 · Answer 1 · answered Dec 07 '12 at 18:09

1

If you're going to do this then you need to take the time to escape every field going into the db using AR's underlying connection escape methods. Otherwise you are just asking for trouble.

Or... use something else that is meant for doing a lot of volume, but still handles the escaping for you... https://github.com/zdennis/activerecord-import

answered Dec 07 '12 at 18:09

Philip Hallstrom

19,673
2
42
46

Unfortunately, Philip, activerecord-import is only for Rails 3. :( – Dawn Green Dec 07 '12 at 18:43
Rats. Then you need to dig down into `AR...connection.escape` to make sure you're properly escaping all the inputs. – Philip Hallstrom Dec 07 '12 at 19:04
I plan to upgrade to 3 early next year and will use the import. – Dawn Green Dec 07 '12 at 20:31

Mike Brant · Answer 2 · 2012-12-07T18:18:27.347

You could consider using MySQL LOAD DATA INFILE syntax to insert your CSV data. It is optimized for upload and doesn't require you to manually build an injection-prone query string.

Here is link to MySQL docs:

http://dev.mysql.com/doc/refman/5.6/en/load-data.html

LOAD DATA [LOCAL] INFILE '/path/to/data.csv'
INTO table
FIELDS TERMINATED BY ',' ENCLOSED BY '' ESCAPED BY '\'
LINES TERMINATED BY '\n'

Note use LOCAL if app server and database are on different machines. you might need to change field and line settings based on the format of your CSV.

score 0 · Accepted Answer · edited May 23 '17 at 10:34

Thanks for all the helpful advice which led me down my final path. I ended up changing my string to an array of values to take advantage of Rails built-in method, sanitize_sql_array after reading another post.

placeholders = []
insert_values = []

csvrow.each do |row|
  placeholders << (?,?,?)
  insert_values << params[:quantity] << #{params[:name]} << {Time.now.to_s(:db)
end

query_string = "INSERT INTO `my_table` (`quantity`, `name`, `created_at`) VALUES #{placeholders.join(", ")}"] + insert_values
sql = ActiveRecord::Base.send(:sanitize_sql_array, query_string)
ActiveRecord::Base.connection.execute(sql)

Sanitize MySQL data in Ruby on Rails 2

3 Answers3