Clearing controls from FlowLayoutPanel not calling destructors?

Question

Sorry if I'm missing something obvious, but I'm trying to clear the controls (a series of user controls) from a FlowLayoutPanel - (panelName).Controls.Clear();. Unfortunately this doesn't seem to be calling the destructors for the objects on the panel - the User Objects column in the task manager just keeps going up and up, until it hits 10,000 and throws an excecption.

Does anyone know what I'm missing here?

I was having the same problem with clearing a bunch of ZedGraph controls from a flowlayoutpanel. I eventually got a "error creating window handle" since it hit 10,000 USER Handles as well. — Miguel Sevilla, Aug 01 '12 at 16:00

score 2 · Answer 1 · answered Aug 01 '12 at 15:59

eftpotrm's workaround above still kept the user handles count growing for me, however, if you just manually dispose after removing the control, that fixed it 100% for me.

while (myFlowLayoutPanel.Controls.Count > 0)
{
     var controltoremove = myFlowLayoutPanel.Controls[0];
     myFlowLayoutPanel.Controls.Remove(controltoremove);
     controltoremove.Dispose();
}

eftpotrm · Accepted Answer · 2009-09-25T09:24:34.657

2

Not a solution, but a workaround - the objects do seem to be destroyed by this (rough, from memory) code:

while(FlowLayoutPanel.Controls.Count > 0)
     FlowLayoutPanel.Controls.Remove(0);

edited Sep 25 '09 at 09:24

answered Sep 09 '09 at 10:39

eftpotrm

2,241
1
20
24

1

A slight variation is: while(FlowLayoutPanel.Controls.Count > 0) { FlowLayoutPanel.Controls.Clear(); } – John M Jul 20 '10 at 14:42
The workaround still kept the user handles count growing for me (disposing Zedgraph control), however, if Ijust manually disposes the control after removing it from the flowlayoutpanel, that fixed it 100% for me (kept the user handles count constant) – Miguel Sevilla Aug 01 '12 at 15:55

score 1 · Answer 3 · answered Sep 04 '09 at 11:30

1

.NET does not have the concept of destructors. .NET has something called "finalizers" which look syntactically like destructors in C#. For more information, check out Jeff Richter's awesome book on how the CLR works -- CLR via C#.

You may want the objects to implement the IDisposable pattern, and then call their Dispose() method when you're done with them.

answered Sep 04 '09 at 11:30

Dave Markle

95,573
20
147
170

Sorry, brain not in gear on the language, I meant finalizers I promise :-) Either way, it's not getting called. The custom control implements IDisposable, which does all it's supposed to. I've tried with a finalizer in case, also destroying the children. I've tried explicitly calling the garbage collector - in all cases, user objects just marches up to 10k and throws an exception. – eftpotrm Sep 04 '09 at 11:51
What's the exception? From what you say, I don't think you fully understand the mechanisms of finalizers and the IDisposable interface... – Dave Markle Sep 04 '09 at 12:21

score 0 · Answer 4 · edited Jun 13 '14 at 06:07

Try using a memory profiler, (e.g. ants) it will tell you what is keeping the control alive. Trying to 2nd guess this type of problem is very hard.

Red-gate gives 14 days tail that should be more then enough time to tack down this problem and decide if a memory profiler provides you with long term value.

There are lots of other memory profilers on the market (e.g. .NET Memory Profiler) most of them have free trials, however I have found that the Red-Gate tools are easy to use, so tend try them first.

Clearing controls from FlowLayoutPanel not calling destructors?

4 Answers4

Linked