Is it okay to use setPreferredSize when using a custom panel?

Question

From previous experience, everyone will say "Don't use those setXxxSize methods! Use a layout manager!" However, what should I do in this case?

import java.awt.*;
import javax.swing.*;

public class Game {
    public static void main(String[] args) {
        new Game();
    }
    public Game() {
        JFrame f = new JFrame("Hi this is a game");
        f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        f.add(new GamePanel());
        f.pack(); 
        f.setVisible(true);
    }
    private class GamePanel extends JPanel {
        private GamePanel() {
            setPreferredSize(600, 600);
        }
        @Override
        public void paintComponent(Graphics g) {
            super.paintComponent(g);
            Graphics2D g2d = (Graphics2D)g;
            //paint stuff
        }
    }
}

This is just some example code I threw together real quick. What should I do when I need to make the game area, say, 600 by 600? Is it okay to use setPreferredSize here? I don't know of any layout manager that can just take a single component and give it a size, and even if there is, isn't it a lot easier to just use this instead of having to use an entire layout manager?

By the way, f.setSize(600, 600) doesn't work here because it takes into account the frame decorations (title bar, border things).

So the question is if I only have one component that needs to be a specific size, what do I do?

[Should I avoid the use of set(Preferred|Maximum|Minimum)Size methods in Java Swing](http://stackoverflow.com/q/7229226/230513)? — trashgod, Dec 11 '12 at 02:00
@trashgod yes, I saw that, but it doesn't really answer my question. If I only have one component that needs to be a specific size, what do I do? — tckmn, Dec 11 '12 at 02:02

Mordechai · Answer 1 · 2012-12-11T02:14:30.050

4

Override getPreferredSize, in GamePanel:

public Dimension getPreferredSize(){
    return new Dimension(600, 600);
}

edited Dec 11 '12 at 02:14

answered Dec 11 '12 at 02:01

Mordechai

15,437
2
41
82

doesn't that essentially do the same thing? – tckmn Dec 11 '12 at 02:02
If you want to allow variable sizes, you'll have to keep a `preferred` reference, changing it as required, and returning it instead. – Mordechai Dec 11 '12 at 02:04
What do you mean, "change it externally?" And I don't need variable sizes, just 600x600. – tckmn Dec 11 '12 at 02:04
`setPreferredsize()` will just do nothin'. – Mordechai Dec 11 '12 at 02:05
no, it will set the panel's size to 600x600. I always have done it this way. – tckmn Dec 11 '12 at 02:05
1

Well, not if you override `getPreferredSize()` :) – Mordechai Dec 11 '12 at 02:06
oh, that makes sense. but why do this and not just `setPreferredSize`? – tckmn Dec 11 '12 at 02:07
could you please clarify why I can't just use `setPreferredSize`? – tckmn Dec 11 '12 at 02:33

score 1 · Accepted Answer · edited May 23 '17 at 12:03

Why do this and not just setPreferredSize()?

As Game is a JPanel that is

Used solely for drawing,
Contains a default layout but no components and
Has a standard UI delegate,

the difference is negligible. There are still reasons to override getPreferredSize()

The intent is clear to other developers; demos and prototypes, like zombies, never go away.
Any one or all of those conditions may change as the class evolves.
It's an idiomatic reminder not to fall into this trap.

Is it okay to use setPreferredSize when using a custom panel?

2 Answers2