ViewPagerIndicator inside a ScrollView

Question

I am using JakeWharton's ViewPageIndicator. I want the height of the pager and the indicator to span around 300dp so that i can more content below it and it can scroll.

<?xml version="1.0" encoding="utf-8"?>
<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:id="@+id/scrollView"
    android:fillViewport="true" >

    <LinearLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:orientation="vertical" >

        <LinearLayout
            android:layout_width="match_parent"
            android:layout_height="300dp"
            android:orientation="vertical" >

            <android.support.v4.view.ViewPager
                android:id="@+id/pager"
                android:layout_width="fill_parent"
                android:layout_height="0dp"
                android:layout_weight="1"
                android:paddingTop="2dp" />

            <com.viewpagerindicator.CirclePageIndicator
                android:id="@+id/indicator"
                android:layout_width="fill_parent"
                android:layout_height="wrap_content"
                android:layout_marginBottom="5dp"
                android:padding="10dip" />
        </LinearLayout>

        <LinearLayout
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:orientation="vertical" >

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:text="Testing something cool" />
        </LinearLayout>
    </LinearLayout>

</ScrollView>

Things Work Perfect. But i am not able to Slide the Viewpagper and it gets really stuck and doesnt slide to the next one. Any one know how to make it work in a confined height ?

******Edit******

Trying to use the solution from Here. Am not very sure if its the right way to Sub-Class Scroll View.

public class PlaceDetailsFragment extends SherlockFragment {
    PlaceSlidesFragmentAdapter mAdapter;
    ViewPager mPager;
    PageIndicator mIndicator;

    public static final String TAG = "detailsFragment";

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
            Bundle savedInstanceState) {
        View view = inflater.inflate(R.layout.fragment_place_details,
                container, false);

        mAdapter = new PlaceSlidesFragmentAdapter(getActivity()
                .getSupportFragmentManager());

        mPager = (ViewPager) view.findViewById(R.id.pager);
        mPager.setAdapter(mAdapter);

        mIndicator = (CirclePageIndicator) view.findViewById(R.id.indicator);
        mIndicator.setViewPager(mPager);
        // ((CirclePageIndicator) mIndicator).setSnap(true);

        mIndicator
                .setOnPageChangeListener(new ViewPager.OnPageChangeListener() {
                    @Override
                    public void onPageSelected(int position) {
                        Toast.makeText(PlaceDetailsFragment.this.getActivity(),
                                "Changed to page " + position,
                                Toast.LENGTH_SHORT).show();
                    }

                    @Override
                    public void onPageScrolled(int position,
                            float positionOffset, int positionOffsetPixels) {
                    }

                    @Override
                    public void onPageScrollStateChanged(int state) {
                    }
                });

        return view;
    }

    public class CustomScrollView extends ScrollView {
        private GestureDetector mGestureDetector;
        View.OnTouchListener mGestureListener;

        public CustomScrollView(Context context, AttributeSet attrs) {
            super(context, attrs);
            mGestureDetector = new GestureDetector(context, new YScrollDetector());
            setFadingEdgeLength(0);
        }

        @Override
        public boolean onInterceptTouchEvent(MotionEvent ev) {
            return super.onInterceptTouchEvent(ev) && mGestureDetector.onTouchEvent(ev);
        }

        // Return false if we're scrolling in the x direction  
        class YScrollDetector extends SimpleOnGestureListener {
            @Override
            public boolean onScroll(MotionEvent e1, MotionEvent e2, float distanceX, float distanceY) {
                if(Math.abs(distanceY) > Math.abs(distanceX)) {
                    return true;
                }
                return false;
            }
        }
    }

}

I would first get rid of the `ScrollView`, then see if your problem goes away. If it does, then the issue is the `ScrollView`, not the constrained height. — CommonsWare, Dec 11 '12 at 19:19
@CommonsWare thanks i think that was the culprit. Now i have to figure out how to make the layout Scroll and yet have the ViewPAger work — Harsha M V, Dec 11 '12 at 19:37
Usually I'll subclass a `ScrollView` that ignores horizontal motion if I'm hosting a `ViewPager` in it. Just FYI. — Brian Dupuis, Dec 11 '12 at 19:41

score 3 · Accepted Answer · answered Dec 21 '12 at 15:16

Have to create a Custom Scroll View and use that

public class VerticalScrollView extends ScrollView {
    View.OnTouchListener mGestureListener;
    private VelocityTracker mVelocityTracker;
    private int mMaximumVelocity;

    public VerticalScrollView(Context context, AttributeSet attrs) {
        super(context, attrs);
        setFadingEdgeLength(0);
        final ViewConfiguration configuration = ViewConfiguration.get(context);
        mMaximumVelocity = configuration.getScaledMaximumFlingVelocity();
    }

    private boolean doNotInterceptUntilUp = false;

    @Override
    public boolean onInterceptTouchEvent(MotionEvent ev) {
        // System.out.println("onInterceptTouchEvent");
        int action = ev.getAction();
        int index = MotionEventCompat.getActionIndex(ev);
        int mActivePointerId = MotionEventCompat.getPointerId(ev, index);

        if (action == MotionEvent.ACTION_DOWN) {
            if (mVelocityTracker == null) {
                mVelocityTracker = VelocityTracker.obtain();
            }
            mVelocityTracker.addMovement(ev);
        } else if (action == MotionEvent.ACTION_MOVE) {
            if (doNotInterceptUntilUp) {
                return false;
            }
            mVelocityTracker.addMovement(ev);
            mVelocityTracker.computeCurrentVelocity(1000, mMaximumVelocity);
            int initialVelocity = (int) VelocityTrackerCompat.getXVelocity(
                    mVelocityTracker, mActivePointerId);
            int initialYVelocity = (int) VelocityTrackerCompat.getYVelocity(
                    mVelocityTracker, mActivePointerId);
            if (Math.abs(initialVelocity) > 100) {
                // 140 is the minimum threshold it seems.
                if (!(Math.abs(initialYVelocity) > 140))
                    doNotInterceptUntilUp = true;
                return false;
            }
        } else if (action == MotionEvent.ACTION_UP) {
            doNotInterceptUntilUp = false;
            if (mVelocityTracker != null) {
                mVelocityTracker.clear();
            }
        }
        boolean val = super.onInterceptTouchEvent(ev);
        return val;
    }
}

XML

<?xml version="1.0" encoding="utf-8"?>
<com.m7.nomad.VerticalScrollView xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res/com.m7.nomad"
    android:id="@+id/scrollView"
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:fillViewport="true" >

    <LinearLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:orientation="vertical" >

        <LinearLayout
            android:layout_width="match_parent"
            android:layout_height="300dp"
            android:orientation="vertical" >

            <android.support.v4.view.ViewPager
                android:id="@+id/pager"
                android:layout_width="fill_parent"
                android:layout_height="0dp"
                android:layout_weight="1" />

            <com.viewpagerindicator.CirclePageIndicator
                android:id="@+id/indicator"
                android:layout_width="fill_parent"
                android:layout_height="wrap_content"
                android:layout_marginBottom="5dp"
                android:paddingBottom="10dip"
                android:paddingLeft="10dip"
                android:paddingTop="1dip" />
        </LinearLayout>

        <LinearLayout
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:orientation="vertical" >

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:text="Testing something cool" />

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:text="Testing something cool" />

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:text="Testing something cool" />

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:text="Testing something cool" />

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:text="Testing something cool" />

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:text="Testing something cool" />

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:text="Testing something cool" />

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:text="Testing something cool" />

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:text="Testing something cool" />
        </LinearLayout>
    </LinearLayout>

</com.m7.nomad.VerticalScrollView>

you have use two number in custom scrollView ( 100 , 140 ) when i've used that scroll not worked correctly for some situation (like fast scroll ) so i've changed that to 1000 , 1400 the worked better, thanks any way for your great answer. — Shayan Pourvatan, Oct 05 '14 at 12:13

ViewPagerIndicator inside a ScrollView

1 Answers1