SharedPreferences return only default value

Question

So instead of creating a database, I'm storing the data using SharedPreference.

My code is below:

   SharedPreferences.Editor editor = getPreferences(MODE_PRIVATE).edit();
        editor.putInt("favid"+id, 1);
        editor.commit();
        Toast.makeText(getApplicationContext(), "Select as favorite", Toast.LENGTH_SHORT).show();

Now I want to retrieve that data so I have used below code in other activity:

   strFav = new ArrayList<Integer>();

    if(strFav.size()>0)
        strFav.clear();
    SharedPreferences prefs = getPreferences(MODE_PRIVATE); 
    for (int i = 1; i < 19; i++) {
        int favid = prefs.getInt("favid"+i, -1);
        if (favid != -1) 
        {
          strFav.add(i);
        }
    }

At time of data retrieve, I'm getting all value is -1.

Can any body help me why this is happening? I have committed many entries as 1, but I'm still getting -1 result for all of them.

score 6 · Accepted Answer · answered Dec 12 '12 at 14:20

6

See docs about getPrefernces method:

Retrieve a SharedPreferences object for accessing preferences that are private to this activity.

So, if you want to share preferences between activities you should use getSharedPreferences with specified name.

answered Dec 12 '12 at 14:20

Jin35

8,602
3
32
52

but jin i have also used "MODE_WORLD_WRITEABLE" but that way it's not done :( – Siddhpura Amit Dec 12 '12 at 15:13
1

If you will use this preferences in your **app** only - you can use MODE_PRIVATE – Jin35 Dec 12 '12 at 15:36

score 1 · Answer 2 · edited May 23 '17 at 11:59

1

Do you use shared preferences in two different activieties of one app ?

Also try to specify preferences name, or use some Manager to handle all preferences, all this explained here

edited May 23 '17 at 11:59

Community

1
1

answered Dec 12 '12 at 14:16

dilix

3,761
3
31
55

thanks a lot dilix by doing SharedPreferences prefs = getSharedPreferences("abc", 0); the problem is solved – Siddhpura Amit Dec 12 '12 at 15:12

score 0 · Answer 3 · answered Dec 12 '12 at 14:03

0

editor.putInt("favid"+id, 1);

what's about id is equals to 0? here you are reading starting from 1

 for (int i = 1; i < 19; i++) {

answered Dec 12 '12 at 14:03

Blackbelt

156,034
29
297
305

are you sure editor.putInt("favid"+id, 1); the id vaules is != 0 when you perform the put? – Blackbelt Dec 12 '12 at 14:05
it does not make sense to me. – Blackbelt Dec 12 '12 at 14:10

SharedPreferences return only default value

3 Answers3

Linked