0

My Entitymanager has no transaction when persisting an object in @PostConstruct. I have no clue why and how to fix this, can anyone help me?

PS. If you need any other data, please ask

TestmachineManager

@Singleton
public class TestmachineManager {
    @PersistenceContext
    private EntityManager em;

    private TimerTask handler = new TimerTask() {
        @Override
        public void run() {
            DayPlanning planning = getPlanning();
            Order order = planning.getNextInLine();
            if(order instanceof Order) {
                em.merge(planning);
                List<String> tests = new ArrayList();
                for(Test test : order.getTests()) {
                    tests.add(test.getName());
                }

                TestmachineSender.orderTests(order.getId(), order.getDomain(), tests);
                timer.schedule(checker, safetycheckAt());
            }
            else {
                timer.schedule(handler, postponeTo());
            }
        }
    };

    @PostConstruct
    public void init() {
        if(getPlanning().hasActiveTest()) {
            handler.run();
        }
    }

    private DayPlanning getPlanning() {
        LocalDate today = new LocalDate(
                Calendar.getInstance().getTime());

        try {
            CriteriaBuilder cb = em.getCriteriaBuilder();
            CriteriaQuery<DayPlanning> query = cb.createQuery(DayPlanning.class);
            Root dayPlanning = query.from(DayPlanning.class);
            Predicate predicateDate = cb.equal(dayPlanning.get("dateOfPlanning"), today.toDate());

            query.select(dayPlanning).where(predicateDate);
            return em.createQuery(query).getSingleResult();
        } catch(NoResultException ex) {
            DayPlanning newPlanning = new DayPlanning(today);
            em.persist(newPlanning);
            return newPlanning;
        }
    }
}

Stacktrace

Caused by: javax.persistence.TransactionRequiredException
    at com.sun.enterprise.container.common.impl.EntityManagerWrapper.doTxRequiredCheck(EntityManagerWrapper.java:163)
    at com.sun.enterprise.container.common.impl.EntityManagerWrapper.doTransactionScopedTxCheck(EntityManagerWrapper.java:145)
    at com.sun.enterprise.container.common.impl.EntityManagerWrapper.persist(EntityManagerWrapper.java:263)
    at TestmachineManager.getPlanning(TestmachineManager.java:130)
    at TestmachineManager.init(TestmachineManager.java:78)
Menno
  • 12,175
  • 14
  • 56
  • 88
  • Have you tried reopening a new transaction in getPlanning method? I guess the one that loaded the object is closed and the entity detached. – Adrian Ber Dec 18 '12 at 13:57
  • Depending upon your IOC container, transaction may not work in @PostConstruct method. http://www.java.net/node/669926 And this might be your solution for spring. http://www.tikalk.com/java/doing-transactional-work-spring-service-using-postconstruct-method – Parvez Dec 24 '12 at 06:49

1 Answers1

0

You have a transaction in @PostConstruct for the Singleton bean. The moment you are loosing your transaction is when you launch a new timer using timer.schedule(checker, safetycheckAt()); or timer.schedule(handler, postponeTo());. I think that the timer object that you are using is actually java.util.Timer, looking at the signature.

You should try using the EJB TimerService resource. For example:

@Resource
private TimerService timerService;

@Timeout
public void run() {
    DayPlanning planning = getPlanning();
    Order order = planning.getNextInLine();
    if(order instanceof Order) {
        em.merge(planning);
        List<String> tests = new ArrayList();
        for(Test test : order.getTests()) {
            tests.add(test.getName());
        }

        TestmachineSender.orderTests(order.getId(), order.getDomain(), tests);

        // if the checker handler doesn't need to run transactionally you could leave it like it was before
        timer.schedule(checker, safetycheckAt());
        // otherwise you could create a checker EJB that uses @Timeout in the same manner or @Scheduled from EJB3.1
    } else {
        // postpone timer
        timerService.createTimer(postponeTo(), "postponed timer information");    
    }
}

@PostConstruct
public void init() {
    if(getPlanning().hasActiveTest()) {
        timerService.createTimer(computeDelay(), "timer information");
        // or you could use the other create methods of the timerService, those that fits your needs better
    }
}

I didn't tested the code, it's just rough code. Hope it helps.

Florin
  • 201
  • 2
  • 5