Form Validation: If data in form contains "VP-", error out

Question

I'm trying to do code that errors out a form validate if the form contains "VP-".

My code is:

// quick order form validation
function validateQuickOrder(form) {        
  if ((form.ProductNumber.value == "")|| (form.ProductNumber.value == "VP")){
        alert("Please enter an item number.");
        form.ProductNumber.focus();
        return false;
 }
        return true;
}

if it IS or if it contains? because you're only checking if it is literally "VP" there. — Aidanc, Jan 03 '13 at 19:14
Expecting to receive the alert, but not receiving anything; form still submitting with no problem using my code above. I want it to encounter a problem, and display alert if I enter a product number that contains "VP" — James Anderson, Jan 03 '13 at 19:14

score 1 · Accepted Answer · edited May 23 '17 at 12:27

== does a full string comparison. You'll want to use indexOf to check if it contains that string:

if ( ~form.ProductNumber.value.indexOf('VP') ) {
    // ProductNumber.value has "VP" somewhere in the string
}

The tilde is a neat trick, but you can be more verbose if you want:

if ( form.ProductNumber.value.indexOf('VP') != -1 ) {
    // ProductNumber.value has "VP" somewhere in the string
}

score 0 · Answer 2 · answered Jan 03 '13 at 19:19

0

Just to provide an alternative to the other answer, regex can be used as well:

if ( /VP/.test( form.ProductNumber.value ) ) {
  // value contains "VP"
}

answered Jan 03 '13 at 19:19

elclanrs

92,861
21
134
171

Form Validation: If data in form contains "VP-", error out

2 Answers2

Linked