stringWithFormat: Format string not a string literal

Question

I've come across a rather weird issue with stringWithFormat:. I create a string and assign it to an alert panel.

For some reason though, Xcode says that the format string isn't a string literal even though it is? Can anyone shed some light?

enter image description here

Header declaration:

APPKIT_EXTERN void NSBeginCriticalAlertSheet(NSString *title, NSString *defaultButton, NSString *alternateButton, NSString *otherButton, NSWindow *docWindow, id modalDelegate, SEL didEndSelector, SEL didDismissSelector, void *contextInfo, NSString *msgFormat, ...) NS_FORMAT_FUNCTION(10,11);

Edit: Looking at the header declaration, it came to me. I was missing a nil after the msgFormat variable. Xcode's warning was confusing though - it should have been missing sentinel in function call instead.

instead of screenshot paste your code here, it will be easier for us to use your code and check. — Anoop Vaidya, Jan 08 '13 at 09:34
we can copy your code and paste in our IDE and compile, edit, correct. Otherwise we have to type exact code.... if we are not master to say only by seeing your code. — Anoop Vaidya, Jan 08 '13 at 09:41
Also, mind if you show us the header declaration for `NSBeginCriticalAlertSheet()`? — TheAmateurProgrammer, Jan 08 '13 at 09:43
@Anoop `_dev.name` originates from a custom object that you don't have, so copying/pasting will not work. @TheAmateurProgrammer It's defined in Panel.h. See edit for declaration. — Pripyat, Jan 08 '13 at 09:45
Post it as an answer so others will know you solved it already. — TheAmateurProgrammer, Jan 08 '13 at 10:31

Ishu · Answer 1 · 2013-01-08T09:56:58.587

0

Use this

 NSString *localizedStr=[NSString stringWithFormat:@"bla bla %@ bla bla",_dev.name];
    NSString *_warning = NSLocalizedString(localizedStr);

    /*code for alert sheet

edited Jan 08 '13 at 09:56

answered Jan 08 '13 at 09:46

Ishu

12,797
5
35
51

That confuses the `NSLocalizedString` macro defined in `Bundle.h` and causes an error. – Pripyat Jan 08 '13 at 09:50

score 0 · Accepted Answer · edited May 23 '17 at 12:04

0

I think the problem is that you try to pass a NSString with a paramater inside a method that does the same. So the NSBeginCriticalAlertSheet is actually looking for another parameter.

If you put it in another NSString stringWithFormat: it takes the literal string instead of trying to parse it.

So in your NSBeginCriticalAlertSheet: _warning should be replaced with

[NSString stringWithFormat:@"%@", _warning]

Also see warning-format-not-a-string-literal-and-no-format-arguments for more information.

edited May 23 '17 at 12:04

Community

1
1

answered Jan 08 '13 at 09:53

Roland Keesom

8,180
5
45
52

1

Actually, I was simply missing a `nil` at the end. :) See my edit. – Pripyat Jan 08 '13 at 10:24

stringWithFormat: Format string not a string literal

2 Answers2