Iterate through ListView and get EditText-Field values

Question

I've created a ListView (myList) with one EditText-Field in each row (R.id.mannschaften). Under the ListView, I've created a Button and set an OnClickListener for it in the OnCreate()-Method. Now when the Button is clicked, I want to iterate through the ListView and get the value of the EditText-Field in every row and save them in a String-List. But how do I do that?

Here is my Code:

private void ButtonClick() {
    /** get all values of the EditText-Fields */
    View v;
    ArrayList<String> mannschaftsnamen = new ArrayList<String>();
    EditText et;

    for (int i = 0; i < myList.getCount(); i++) {
        v = myList.getChildAt(i);
        et = (EditText) v.findViewById(R.id.mannschaften);
        mannschaftsnamen.add(et.getText().toString());
    }
    .....
}

I already know, that getChildAt is only for the visible rows, but I don't know how to do it differently.

score 36 · Answer 1 · answered Apr 21 '14 at 15:26

36

When you use myList.getAdapter().getView(i,null,null) you are getting a new instance of the item view, try the ListView.getChildAt(position) method like this:

private void ButtonClick() {
    /** get all values of the EditText-Fields */
    View v;
    ArrayList<String> mannschaftsnamen = new ArrayList<String>();
    EditText et;
    for (int i = 0; i < myList.getCount(); i++) {
        v = myList.getChildAt(i);
        et = (EditText) v.findViewById(R.id.editText1);
        mannschaftsnamen.add(et.getText().toString());
    }
....
}

answered Apr 21 '14 at 15:26

Mohamed F

794
1
8
13

But adapter size can be different from the listview size. – Diffy Oct 06 '14 at 18:29
1

`myList.getCount()` or `myList.getChildCount()`? The latter looks like more consistent – espinchi Dec 15 '14 at 22:35

score 20 · Accepted Answer · answered Jan 13 '13 at 11:53

20

Solved the Problem with the help of a friend:

private void ButtonClick() {
    /** get all values of the EditText-Fields */
    View v;
    ArrayList<String> mannschaftsnamen = new ArrayList<String>();
    EditText et;
    for (int i = 0; i < myList.getCount(); i++) {
        v = myList.getAdapter().getView(i, null, null);
        et = (EditText) v.findViewById(i);
        mannschaftsnamen.add(et.getText().toString());
    }
....
}

answered Jan 13 '13 at 11:53

Andreas Schneider

2,855
3
18
18

1

I am trying this code but the et or relevant field always returns null for me. Do you know why? – tejas Jul 05 '13 at 09:40
1

This line et = (EditText) v.findViewById(i); throws me null, can you guess why? – tejas Jul 05 '13 at 10:47
1

do you know why et = (EditText) v.findViewById(i); throws null? – lolliloop Jul 23 '13 at 04:36
2

Maybe because you need to supplement it with the real name of that element in XML? – manWe Aug 06 '13 at 12:22
4

`findViewById()` is supposed to take resource ID and not the index! – TechSpellBound Jul 22 '15 at 00:58
here, above code is working fine. after entered editext values, am trying to get, that time getting empty values only from EditText.. – harikrishnan Apr 27 '16 at 07:24

nang_kring · Answer 3 · 2014-06-16T07:05:39.297

I think the answer from @Arius was quite close to be right solution. I just want to highlight that View you should get is View which contain with ListView. So you need to getChildAt(position) related with your ListView.

private void ButtonClick() {
/** get all values of the EditText-Fields
find your ListView local variable you had created for example :
private ListView listview; 
You also need to catch null value of EditText first. */
ArrayList<String> mannschaftsnamen = new ArrayList<String>();
EditText et;
    for (int i = 0; i < listview.getCount(); i++) {
        et = (EditText) listview.getChildAt(i).findViewById(R.id.editText1);
        if (et!=null) {
           mannschaftsnamen.add(String.valueOf(et.getText()));

           /** you can try to log your values EditText */
           log.v("ypgs", String.valueOf(et.getText()));
        }
    }
    ....
}

score 0 · Answer 4 · answered May 19 '14 at 13:17

Regarding why the selected answer might sometimes throw a null on the "et = (EditText) v.findViewById(i);"

Would it not be at that point trying to select the item at position i WITHIN the view that you had previously selected? Thus if there are fewer items in the child views than there are items in the whole list, you would get null due to i trying to select items that don't exist.

Perhaps a nested loop could solve this problem? Or if you already know the index of the element you need, simply give it the index directly.

Iterate through ListView and get EditText-Field values

4 Answers4

Linked