Multiple Pen objects C#

Question

I have a form in which i draw some lines using the Pen object.

I'm wondering if i should use one shared object Pen, or one object Pen per line drawn.

Is is better to use: (one object shared by all lines)

Pen green;
green = new Pen(Color,size);
foreach(line to be drawn)
   graphics.DrawLine(green, x1, y1, x2, y2);

Or the following: (each line is an object)

foreach(line to be drawn)
   Pen green = new Pen(Color.Green, 3);
   graphics.DrawLine(green, x1, y1, x2, y2);
   green.Dispose();

In fact, both examples do what I want, but i'm wondering what is most recommended in this case.

Note: I'm using C# (WinForms)

The compiler/jitter should optimize it for you, but since Pen is a win32 unmanaged resource I'd suggest 1 instance with a `using` clause around it. — asawyer, Jan 17 '13 at 16:18

Mehmet Ataş · Accepted Answer · 2013-01-17T17:49:19.010

4

If I were you

using (var green = new Pen(Color,size)
{
    foreach(line to be drawn)
    {
        graphics.DrawLine(green, x1, y1, x2, y2);
    }
}

edited Jan 17 '13 at 17:49

answered Jan 17 '13 at 16:30

Mehmet Ataş

This seems a good option. According to msdn the `using` statement "The using statement obtains one or more resources, executes a statement, and then disposes of the resource." Thanks. – guanabara Jan 17 '13 at 16:43

score 2 · Answer 2 · edited May 23 '17 at 11:49

2

Take a look at this one: What happens if I don't call Dispose on the pen object? It seems to be perfectly explained here ...

To keep it short, this one seems to be better :

Pen green = new Pen(Color,size);

foreach(line to be drawn)
   graphics.DrawLine(green, x1, y1, x2, y2);

green.Dispose();

edited May 23 '17 at 11:49

Community

answered Jan 17 '13 at 16:23

Leo Chapiro

2 Answers2