MVC - display all images in single page as gallery from database?

Question

I stored few images in sql server database in binary format and then retrieved them back and im able display as image but my requirement is that i should display all the images as gallery from database but im able to display only the 1st image as gallery...

my problem is in my controller code as in the forloop its returning file for the first loop itself and view is displayed

Controller

public ActionResult DislpayAllImage()
{
    DataSet dsa = new DataSet();
    dsa = objImage.getAllImages();
    DataTable dt = new DataTable();
    dt = dsa.Tables[0];
    if (dt != null)
    {
        for (int i = 0; i < dt.Rows.Count; i++)
        {
            Byte[] image = (Byte[])dt.Rows[i]["UsImage"];
            return File(image, "image/jpg");
        }
    }

    return View();
}

View

@foreach( var image in ViewData.Images )
{
    <img src="@Url.Action("DislpayAllImage", "Home",new { id = image.ImageID })" />
}

displaying more than 1 image in single page from datatbase – colors bright Jan 23 '13 at 10:08 — colors bright, Jan 23 '13 at 10:08

score 1 · Answer 1 · answered Jan 23 '13 at 10:29

1

MVC controller can return only once! Try it:

ViewData.Images = new List<byte[]>();
for (int i = 0; i < dt.Rows.Count; i++)
{
   dt.Rows.Add((Byte[])dt.Rows[i]["UsImage"]);
}

answered Jan 23 '13 at 10:29

Slovo

212
2
11

score 0 · Answer 2 · answered Jan 23 '13 at 10:23

0

Well first of all you can't do return File(image, "image/jpg"); in your for loop as it will return the first image as you wrote in your explanation.

So instead of returning in the for loop how about you collect the images and return the list?

List<File> fileList = new List<File>();
for (int i = 0; i < dt.Rows.Count; i++)
        {
            Byte[] image = (Byte[])dt.Rows[i]["UsImage"];
            fileList.Add(File(image, "image/jpg"));
        }

and then return your view with the images as a parameter.

return View(fileList);

answered Jan 23 '13 at 10:23

Moriya

7,750
3
35
53

nice but getting error inthis line fileList.Add(Image(image, "image/jpg"));...note my model name is Image and i decalred list in this way List fileList = new List(); – colors bright Jan 23 '13 at 10:39
Image is a type but used like a variable? – colors bright Jan 23 '13 at 11:49
is it possbile to hold images in list?? – colors bright Jan 23 '13 at 11:59
What is the return type of this? `File(image, "image/jpg")` – Moriya Jan 23 '13 at 12:06
this is returning me image, and Image is my model name – colors bright Jan 23 '13 at 12:09
@colorsbright then what you want to do is `List imageList = new List();` `imageList.Add(File(image, "image/jpg"));` – Moriya Jan 23 '13 at 12:10
im not getting the keyword File – colors bright Jan 23 '13 at 12:11
in the code you posted you do `return File(image, "image/jpg");` if what you say in the comments is correct you have a method called **File** that returns **Image**. – Moriya Jan 23 '13 at 12:13
imageList.Add(File(image, "image/jpg"));..here im getting the error as 'the best overload match for....has some invalid arguments..ru sure that list can hold images?? – colors bright Jan 23 '13 at 12:13
If Image is a class then, YES! – Moriya Jan 23 '13 at 12:24
my Image is a class then?? – colors bright Jan 23 '13 at 12:39
Let's do this again... What is the return type of the method `File(image, "image/jpg")`? if that is an `Image` then you should have no problem putting said `Image` in a `List` – Moriya Jan 23 '13 at 12:45
but my issue is in this line imageList.Add(File(image, "image/jpg"));?? – colors bright Jan 23 '13 at 13:07
@colorsbright, it's very difficult to help you if you don't answer any questions. I don't have all of your code so I don't know what you are trying to do. I can only make assumptions and ask you for more info which you don't give me. – Moriya Jan 23 '13 at 13:09
thnku for sparing ur valuable time – colors bright Jan 24 '13 at 04:31

score 0 · Accepted Answer · answered Jan 23 '13 at 12:15

0

This is just a notion, not entire code is properly implemented and tested.

[HttpGet]
public ActionResult Index()
{
   ViewData["count"]=..count the number of rows which have binary image data
}

Then in your view get the view data and loop through

@for(int i=0;i<=ViewData["count"];i++)
{
   <img src="@Url.Action("DislpayAllImage", "Home",new { id = i})" />
}

Then in your controller

[HttpPost]
public ActionResult Index(int id)
{
        DataSet dsa = new DataSet();

        dsa = objImage.getUserImage(id);
        Byte[] imagedata = (Byte[])dsa.Tables[0].Columns["MyImage"];
        return File(imagedata, "image/jpg");

}

Hope it helps

answered Jan 23 '13 at 12:15

Karthik Chintala

5,465
5
30
60

yes, but the problem here is return File(imagedata, "image/jpg");, is just returning image here, the view is not getting called – colors bright Jan 23 '13 at 12:21
What do you see in your view ? – Karthik Chintala Jan 23 '13 at 12:29
my view is not even being called – colors bright Jan 23 '13 at 12:32
im getting compilation error in my view near forloop as 'Operator '<=' cannot be applied to operands of type 'int' and 'object'' – colors bright Jan 23 '13 at 12:39
@colorsbright the idea is to get that `ViewData["count"]` to the view and loop throught to get images – Karthik Chintala Jan 24 '13 at 04:17
thnku, ur idea worked great for me...i changed the view like this...@for(int i=1;i<=Convert.ToInt32(ViewData["count"]);i++) { } – colors bright Jan 24 '13 at 04:29
can we make alignmnet for this? – colors bright Jan 24 '13 at 04:30
Yes you can, better give a try at first and if you dont get it then you can search for it – Karthik Chintala Jan 24 '13 at 04:34
how about pdf files,im storing few pdf files also along with images, so i want that pdf files to be downloaded automatically? – colors bright Jan 24 '13 at 05:44
[Check this](http://stackoverflow.com/a/5830215/1551730) post and entire thread as well – Karthik Chintala Jan 24 '13 at 05:51
what value does the variable document holds in that post, binary value of pdf?? also im not getting document.FileName,document.Data, document.ContentType after typing document? – colors bright Jan 24 '13 at 06:42

MVC - display all images in single page as gallery from database?

3 Answers3