Where should a logger(log4j) be initialized in a servlet?

Question

I am initializing the logger in servlet's constructor. Is it a good practice? Should I rather initialize it in a servletContextListener?

Sample Code:

public class MyService{
Logger logger;

 public MyService(){
   logger = Logger.getLogger(MyService.class);
 }

}

Have a look at: http://stackoverflow.com/questions/3842823/should-logger-be-private-static-or-not — condit, Jan 25 '13 at 16:34

score 3 · Answer 1 · edited Jun 20 '20 at 09:12

3

Use the logger as a Class level member by declaring it as static

Initialize it properly

Little How-to

private static final Logger logger = Logger.getLogger(*<yourclass>*.class)

edited Jun 20 '20 at 09:12

Community

answered Jan 25 '13 at 12:20

TheWhiteRabbit

@user1348308 You should follow this advice even if using a different logging framework. (Some exceptions may apply of course.) – barfuin Jan 25 '13 at 14:38

score 0 · Answer 2 · answered Jan 25 '13 at 08:02

0

I think you're talking about initializing the log4j logging system, not a specific logger.

Use servletContextListener is better than the servlet's constructor.

answered Jan 25 '13 at 08:02

Jintian DENG

2 Answers2