validating an email address properly with PHP

Question

I am trying to write a script that does the following: Prints the users message to the screen and emails it to them as well.

here is my code For some reason it tells me my email address is invalid when it is a valid email address, any suggestions? what am i missing? :-\

<?php
  if(strtolower($_SERVER['REQUEST_METHOD']) == 'post');

  $errors = null;
  $success = true;

  function checkEmail($email){
      return filter_var($email, FILTER_VALIDATE_EMAIL);
}

 if($_POST){
$errors = array();
$to = $_POST['email'];
$subject = 'Your Comment';
$message = $_POST['message'];
$headers = 'From: blahblah69@gmail.com' . "\r\n" . 'Reply-To:
     mitides.constantin@gmail.com' . "\r\n" .
            'X-Mailer: PHP/' .phpversion();



if(!$to || !$message){
    $errors[] ="Please fill in both a email and a message.";
} else if(!checkEmail($to) && $_POST['message'] = filter_var($_POST['message'],
   FILTER_SANITIZE_STRING));{
    $errors[]= print ('You did not enter a valid email, please try again.');
 }
 if($errors || !$_POST){

    if($errors){
        foreach($errors as $error){
            echo $error. "<br />";
        }
    }
}
if(!$errors && $success){
    mail($to, $subject, $message, $headers) && print($_POST['message']);

  } ?>

You can't count on 50 pairs of hands how many questions are similar to this. — jeremy, Jan 26 '13 at 17:25
@WaleedKhan It's not so much wrong as it is confusing ;-) because the final result is the same — Ja͢ck, Jan 26 '13 at 17:28
@Nile I wouldnt have posted it if i found those questions useful — cdm89, Jan 26 '13 at 17:29
@user1905577 Maybe you just don't know *how* to use those questions. — jeremy, Jan 26 '13 at 17:29
@WaleedKhan That will actually just make a new value in $errors of `1`. — jeremy, Jan 26 '13 at 17:30
@WaleedKhan Thanks, what do you mean it is wrong would you mind explaining what the right way to write it is? — cdm89, Jan 26 '13 at 17:31
Anyone?... It may be something simple but I'm a beginner Id really appreciate the help, Although there are similar questions to it I still dont understand it, kindness would be appreciated — cdm89, Jan 26 '13 at 17:48
Have you tried to just isolate the value of `filter_var($email, FILTER_VALIDATE_EMAIL);`? Does it return `false`? — Ja͢ck, Jan 26 '13 at 17:53
Isolating it seemed to work but im curious to know why it didnt work when i had my code checking two things at once, I was trying to make it more clean/ less code to type but i guess that was a fail lol (i also fixed the errors[] = print thing ...I see why that wasnt necessary — cdm89, Jan 26 '13 at 18:42

score 0 · Answer 1 · answered Jan 26 '13 at 18:24

0

at first put else if part in a bracket such like this ($_POST['message'] = filter_var($_POST['message'],FILTER_SANITIZE_STRING))

answered Jan 26 '13 at 18:24

M K Garwa

495
2
13

validating an email address properly with PHP

1 Answers1