Making a program that ask the user 5 questions in random without duplicate the questions

Question

Possible Duplicate:
Randomize a List<T> in C#

I want to make a program that ask the user 5 questions in random without duplicate the questions, and if the question is right go through the next question if wrong stop until he gave the right answer, and this is the code which I had written, but there are still some problems, like there are duplicate and when the user enter the wrong answer it only stop for one time, and then the program closed! now how can I prevent duplicate the same question, and if he enter wrong value don't proceed to the next question or the program closed?

static void Main()
{
    next:
    Random question = new Random();
    int x = question.Next(5);
    string[] array = new string[5];
    array[0] = "-What is the capital of France";
    array[1] = "-What is the capital of Spain";
    array[2] = "-What is the captial of Russia";
    array[3] = "-What is the capital of Ukraine";
    array[4] = "-What is the capital of Egypt";

    Console.WriteLine(array[x]);

    string[] answer = new string[5];
    answer[0] = "Paris";
    answer[1] = "Madrid";
    answer[2] = "Moscow";
    answer[3] = "Kiev";
    answer[4] = "Cairo";

    string a = Console.ReadLine();

    if (a == answer[x])
    {
        Console.WriteLine("It's True \n*Next Question is:");
        goto next;
    }
    else
        Console.WriteLine("It's False \n*Please Try Again.");

    Console.ReadLine();
}

Please ask specific questions (multiple questions if necessary), not one of the "this doesn't work, please fix" type. Also please remove this `goto`. — ken2k, Jan 29 '13 at 17:17
OMG please don't use GOTO. [That's the Devil himself](http://stackoverflow.com/questions/2949420/why-using-goto-is-bad-programming) — Federico Berasategui, Jan 29 '13 at 17:20
@user2022523 [Flow Control](http://zetcode.com/lang/csharp/flowcontrol/) — Federico Berasategui, Jan 29 '13 at 17:38

Sergey Berezovskiy · Accepted Answer · 2013-01-29T20:30:56.687

3

You can shuffle indexes of asked question with LINQ

Random random = new Random();
var indexes = Enumerable.Range(0,array.Length).OrderBy(i => random.Next());

foreach(var index in indexes)
{
    Console.WriteLine(array[index]);
    do 
    {        
        string a = Console.ReadLine();

        if (a == answer[index]) {                
          Console.WriteLine("It's True\n");
          break;
        }

        Console.WriteLine("It's False \n*Please Try Again.");
    }
    while(true);
}

Explanation:

Enumerable.Range(0,array.Length) will return range of integer values starting from zero: 0, 1, 2, 3, 4. Next those numbers will be sorted by random number (i.e. shuffled). It could result in any combination of those numbers, e.g. 3, 0, 1, 4, 2.

BTW it's good to go OOP way and put related data (question text and answer) and logic (defining if answer is correct) into one place:

public class Question
{
    public string Text { get; set; }
    public string Answer { get; set; }

    public bool IsCorrect(string answer)
    {
        return String.Compare(answer, Answer, true) == 0;
    }
}

With this question class all your code will be more readable:

var questions = new List<Question>()
{
    new Question { Text = "What is the capital of France?", Answer = "Paris" },
    new Question { Text = "What is the capital of Spain?", Answer = "Madrid" },
    new Question { Text = "What is the capital of Russia?", Answer = "Moscow" },
    new Question { Text = "What is the capital of Ukraine?", Answer = "Kiev" },
    new Question { Text = "What is the capital of Egypt?", Answer = "Cairo" }
};

Random random = new Random();

// randomizing is very simple in this case
foreach (var question in questions.OrderBy(q => random.Next()))
{
    Console.WriteLine(question.Text);

    do
    {
        var answer = Console.ReadLine();
        if (question.IsCorrect(answer))
        {
            Console.WriteLine("It's True");
            break;
        }

        Console.WriteLine("It's False. Please try again.");
    }
    while (true);
}

Next step for you is implementing Survey class, which will hold question asking, reading answers and displaying summary.

edited Jan 29 '13 at 20:30

answered Jan 29 '13 at 17:17

Sergey Berezovskiy

232,247
41
429
459

There are more [efficient algorithm](http://stackoverflow.com/questions/273313/randomize-a-listt-in-c-sharp) to shuffle a list. However, this solution can be quilcly implemented. – Cédric Bignon Jan 29 '13 at 17:21
Less efficient, but more readable. Still don't understand why downvoted. Somebody don't know LINQ I suppose. Also I don't think `0.001 ms` is a big deal here. Is it? – Sergey Berezovskiy Jan 29 '13 at 17:22
1

In this case, absolutely not. And I'm quite interested too to know why you've been downvoted. – Cédric Bignon Jan 29 '13 at 17:25
This is a good answer, +1 to offset whomever downvoted it. – Brian Jan 29 '13 at 17:31
@Brian thanks! That was what I call **envious downvoter** i.e. when correct answer is being downvoted without any explanations. – Sergey Berezovskiy Jan 29 '13 at 17:33
1

@lazyberezovsky - Haha! I couldn't agree with you more! And, you are welcome. – Brian Jan 29 '13 at 17:34
@user2022523 - Don't forget to make an answer for this question, please! – Brian Jan 29 '13 at 17:40
@Brian looks like some guys here have psychological problems :) – Sergey Berezovskiy Jan 29 '13 at 17:47
1

@lazyberezovsky .. sure I will but I cant do this before "7 - hours" so sure I will :) – Bahinour Jan 29 '13 at 17:49
@lazyberezovsky .. just want to inquire if I want to add a timer with "10 sec." for each question if the user haven't answer I change the question, do you have any class to do this or have any idea? – Bahinour Jan 29 '13 at 17:50
@user2022523 well, look here http://stackoverflow.com/questions/57615/how-to-add-a-timeout-to-console-readline – Sergey Berezovskiy Jan 29 '13 at 17:55

score 3 · Answer 2 · answered Jan 29 '13 at 17:31

Do not use goto unless it is absolutely necessary.

public class Program
{
    private static List<KeyValuePair<string, string>> questions = new List<KeyValuePair<string, string>>
    {
        new KeyValuePair<string,string>("-What is the capital of France", "Paris"),
        new KeyValuePair<string,string>("-What is the capital of Spain", "Madrid"),
        new KeyValuePair<string,string>("-What is the captial of Russia", "Moscow"),
        new KeyValuePair<string,string>("-What is the capital of Ukraine", "Kiev"),
        new KeyValuePair<string,string>("-What is the capital of Egypt", "Cairo"),
    };

    static void Main()
    {
        var questions = ShuffleQuestions();

        foreach(var question in questions)
        {
            bool done = false;
            while(!done)
            {
                Console.WriteLine(question.Key);
                string a = Console.ReadLine();

                if (a == question.Value)
                {
                    Console.WriteLine("It's True \n*Next Question is:");
                    done = true;
                }
                else
                    Console.WriteLine("It's False \n*Please Try Again.");
            }
        }

        Console.ReadLine();
    }

    private IEnumerable<KeyValuePair<string, string>> ShuffleQuestions()
    {
        var list = questions;
        var random = new Random();  
        int items = list.Count;  
        while (items > 1) {  
            items--;  
            int nextItem = random.Next(items + 1);  
            var value = list[nextItem];  
            list[nextItem] = list[items];  
            list[items] = value;  
        }

        return list;
    }
}

itsme86 · Answer 3 · 2013-01-29T17:49:07.293

You could create a shuffled array of integers that represent the order to ask the questions in:

// Create question order
var order = Enumerable.Range(0, array.Length).ToArray();
for (int i = order.Length - 1; i > 1; --i)
{
    var randomIndex = rnd.Next(i);
    var temp = order[randomIndex];
    order[randomIndex] = order[i];
    order[i] = temp;
}

// Ask the questions in shuffled order
foreach(int questionIndex in order)
{
    Console.Write(array[questionIndex]);
    bool answeredCorrectly = Console.ReadLine() == answer[questionIndex];
}

Making a program that ask the user 5 questions in random without duplicate the questions

3 Answers3