Javascript Array in for loop returns undefined

Question

When I loop this array with a for loop it somehow gives me undefined in

updateField(this.value, vehicles[i]+"_brand"

While

$("#"+vehicles[i]+"_year").change(function(){

Does get the right values of the array. How can this be and how can I solve this?

var vehicles = new Array();
    vehicles[0] = "auto";
    vehicles[1] = "truck";
    vehicles[2] = "motor";

for(var i = 0;i < vehicles.length;i++){
    $("#"+vehicles[i]+"_year").change(function(){
       updateField(this.value, vehicles[i]+"_brand", 1, 2, this.parentNode.id), resetBelow(0,'auto'), show('auto_brand');
    });
}

Trust me the only issue is the vehicles[i]+"_brand" and I think thats because its in the jquery change function — Sinan Samet, Feb 05 '13 at 09:32
duplicate of [Javascript closure inside loops - simple practical example](http://stackoverflow.com/questions/750486/javascript-closure-inside-loops-simple-practical-example) — Bergi, Feb 05 '13 at 09:42

Adil · Answer 1 · 2013-02-05T09:34:48.833

1

The time the change event will be fired vehicles[i] will be evaluated again and you will be having the last value of i.

Change

vehicles[i]+"_brand"

To

this.id.split('_')[0]+"_brand"

edited Feb 05 '13 at 09:34

answered Feb 05 '13 at 09:27

Adil

146,340
25
209
204

This returns in the console: Object [object Object] has no method 'split' – Sinan Samet Feb 05 '13 at 09:34
I missed the id check my updated answer. – Adil Feb 05 '13 at 09:35
I think it doesnt get the id I get: "Cannot call method 'split' of undefined" now. Sorry im not good with js but this does seem like the right answer. – Sinan Samet Feb 05 '13 at 09:37

score 0 · Answer 2 · answered Feb 05 '13 at 09:29

It looks like you're having commas where semicolons should be to me:

updateField(this.value, vehicles[i]+"_brand", 1, 2, this.parentNode.id); resetBelow(0,'auto'); show('auto_brand');

... or maybe your updateField() function has more parameters and you simply closed the function prematurely?

Javascript Array in for loop returns undefined

2 Answers2