Download all types of files from server using ASP.NET

Question

I have a file in server .

I want download this file .

I use this code

try
    {
        Response.Clear();
        Response.ClearContent();
        Response.ClearHeaders();
        Response.BufferOutput = true;

        if (File.Exists(Server.MapPath("~/Upload/" + file)))
        {
            Response.AddHeader("Content-Disposition", "attachment; filename=" + file);
            Response.ContentType = "application/octet-stream";
            Response.WriteFile(("~/Upload/" + file));
            Response.End();
            HttpContext.Current.ApplicationInstance.CompleteRequest();
        }
        else
        {
            if (Request.UrlReferrer != null)
            {
                Type csType = GetType();
                string jsScript = "alert('File Not Found');";
                ScriptManager.RegisterClientScriptBlock(Page, csType, "popup", jsScript, true);
            }
        }
    }
    catch (Exception ex)
    {
        string errorMsg = ex.Message;
        ScriptManager.RegisterClientScriptBlock(Page, GetType(), "popup", errorMsg, true);
    }

But when i use this, I get error

Unable to evaluate expression because the code is optimized or a native frame is on top of the call stack.

in code

Response.End();

How to download all types of files?

score 0 · Answer 1 · answered Feb 07 '13 at 08:15

0

Is this Web Forms, MVC, or a custom IHttpHandler?

In any event, you don't need to call Response.End() or HttpContext.Current.ApplicationInstance.CompleteRequest(), just return from your function and ensure nothing else is written to the response.

answered Feb 07 '13 at 08:15

Dai

141,631
28
261
374

Thanks a lot, This is a Web Forms. I remove `Response.End() HttpContext.Current.ApplicationInstance.CompleteRequest()`, I don't get error but don't download file . – Niloo Feb 07 '13 at 08:18
Are you able to debug your code? Can you step-through your code and see if any exceptions are thrown or caught? Consider removing your `try/catch` block. – Dai Feb 07 '13 at 08:23
Yes I debug it, but don't any exceptions are thrown or caught. – Niloo Feb 07 '13 at 08:28

score 0 · Answer 2 · answered Feb 07 '13 at 08:29

0

Have you tried :

Response.TransmitFile(Server.MapPath("~/Upload/" + file));

instead of :

Response.WriteFile(("~/Upload/" + file));

You should also remove the BufferOutput (bad idea with Response.End() without Response.Flush())

answered Feb 07 '13 at 08:29

jbl

15,179
3
34
101

Ah, good catch, I didn't see that buffering was enabled. That explains it. – Dai Feb 07 '13 at 08:34
Thanks a lot, I use this `Response.TransmitFile(Server.MapPath("~/Upload/" + file));` but won't download. – Niloo Feb 07 '13 at 08:38
@Niloo You shoud also remove the Response.BufferOutput = true; – jbl Feb 07 '13 at 08:39
I remove it, but don't download :( – Niloo Feb 07 '13 at 09:00

Download all types of files from server using ASP.NET

2 Answers2

Linked