How do I compare values from lists against parameters in java?

Question

I am trying to create a function that that checks if a level is held within an SQLite database. If it is, and the new score is greater than the score in the table then I want to edit it. I have created an edit function that seems to work fine and an add to database function that is called when the level being checked doesn't exist.

Here is my function

    void isHighScore(String level, int score) {
    List<String> scores = getHighScore();
    List<String> levels = getHighScoreLevel();

    for (int i = 0; i < levels.size(); i++) {

        int scoreVal = Integer.parseInt(scores.get(i));
        String levelVal = levels.get(i).toString();

        if (levelVal == level && scoreVal < score) {
            try {
                editScore(level, score);
            } catch (Exception e) {}
        }
    }
    if (!levels.contains(level)) {
        createHighScoreEntry(level, score);
    }
}

So far, only the create entry function is working, so my main problem resides in the for loop. Any help will be greatly appreciated.

Check out this: - [How to Compare Strings](http://stackoverflow.com/q/513832/1679863) — Rohit Jain, Feb 09 '13 at 16:13
are scores and levels lists always in the same size ? if not accessing scores.get(i) can get you a null pointer exception — Nimrod007, Feb 09 '13 at 16:15

score 0 · Answer 1 · answered Feb 09 '13 at 16:14

You shouldn't be using == to compare strings because it doesn't check to see if the strings are actually equal. What you should be using is String.equals() or String.compare() or String.contains()

String.equals() checks to see if they are equal. If so it returns true

String.compare() checks to see if they are equal. If they are it returns 0 if not it returns -1 or 1 depending on the differences.

String.contains() is more generic and checks to see if a word, character or phrase is contained in your string if it is it returns true.

You can use this site as a reference for what each does http://docs.oracle.com/javase/1.5.0/docs/api/java/lang/String.html

How do I compare values from lists against parameters in java?

1 Answers1