Passing variable to window.location href

Question

I'm trying to delay outgoing links when clicked, so that googles event tracking have time to occur.

I wrote the following code, but I'm unsure of how to pass my variable to window.location. It just adds it as string "url" and not the link adress. What am I doing wrong?

$("a.private-product-order-button").click(function(e) {
   e.preventDefault();
   _gaq.push(['_trackEvent', 'Order buttons', 'Click', 'Service']);
   var url = $(this).attr("href");
   setTimeout(function() {
      $(window.location).attr('href', 'url');
      }, 200);
});

window.location.href=url - you are over jQuerying it – mplungjan Feb 13 '13 at 09:37 — mplungjan, Feb 13 '13 at 09:37
@mplungjan: Is such a thing even possible? – Blender Feb 13 '13 at 09:38 — Blender, Feb 13 '13 at 09:38

score 2 · Answer 1 · answered Feb 13 '13 at 09:38

2

No need to use jQuery to set a property of the location object (and no need to use jQuery to get href property of the anchor object):

$("a.private-product-order-button").click(function(e) {
    e.preventDefault();
    _gaq.push(['_trackEvent', 'Order buttons', 'Click', 'Service']);

    var url = this.href;
    setTimeout(function() {
        window.location.href = url;
    }, 200);
});

answered Feb 13 '13 at 09:38

dfsq

191,768
25
236
258

Thank's. I'm so new to this, doing things the "right way" is a work in progress. – Johan Dahl Feb 13 '13 at 09:44

score 1 · Answer 2 · answered Feb 13 '13 at 09:37

1

Because you're adding string after all.

It should be:

$(window.location).attr('href', url);

not

$(window.location).attr('href', 'url');

answered Feb 13 '13 at 09:37

kidwon

4,448
5
28
45

Ohh damnit it was so easy. Thanks. – Johan Dahl Feb 13 '13 at 09:40

score 1 · Answer 3 · answered Feb 13 '13 at 09:38

1

Use $(window.location).attr('href', url); without the quotes around url.

answered Feb 13 '13 at 09:38

Jerry Joseph

1,002
8
14

Passing variable to window.location href

3 Answers3