Passing a String value across Activities?

Question

I am currently attempting to pass a string across activities. The string is used to set an image in the second activity. So the user is clicking a button in the first activity and then the appropriate image is loaded in the second activity based upon what was selected. There are three buttons in the first activity all which should send a String value to the next activity.

This is what I have in my first activity:

Button archerButton = (Button) findViewById(R.id.Button_Archer);
archerButton.setOnClickListener(new View.OnClickListener() {
    public void onClick(View v) {
        String selection = "archer";
        Bundle basket = new Bundle();
        basket.putString("key", selection);
        Intent i = new Intent(SelectCharacterActivity.this, LevelOneActivity.class);
        i.putExtras(basket);
        startActivity(i);
        finish();
        }
    });
}

The receiving activity has the following code:

public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE);
    setContentView(R.layout.level_one);

    ImageView img = (ImageView) findViewById(R.id.Character_Chosen);

    Bundle extras = getIntent().getExtras();
    String Toon = extras.getString("key");

    if(Toon=="archer"){
        img.setImageResource(R.drawable.archer);
    }

    if(Toon=="mage"){
        img.setImageResource(R.drawable.mage);
    }
    if(Toon=="warrior"){
        img.setImageResource(R.drawable.warrior);
    }
}

I know that the receive if statements section works because if I manually set the value Toon the image will load. So somewhere the information is not being sent or read properly. I followed a tutorial online and but am stumped on this.

Please see [How do I compare strings in Java?][1] for comparing Strings in Java [1]: http://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java — AlexVogel, Feb 18 '13 at 15:10

score 2 · Answer 1 · answered Feb 18 '13 at 15:08

You are comparing your strings wrong,

Toon=="Anything"

will never be true, you need to use

Toon.equals("Anything")

for it to work.

EDIT:

This is true because "==" will just compare the memory addresses of the Strings, and "Anything" will just have been allocated and definitely won't match Toon. .equals however actually compares the chars in the string.

Also to test things like this try putting in a

Log.i("YourAppName", "Toon value is: " + Toon);

after

String Toon = extras.getString("key");

score 2 · Accepted Answer · answered Feb 18 '13 at 15:08

issue is Java 101. string equality test is done using the equals method.

Toon.equals("archer");

Extra tip : inverse your test to avoid null pointer exception :

"archer".equals(Toon);

Extra extra tip : considering your cases are mutually exclusive, use if else if to avoid testing all cases.

score 0 · Answer 3 · answered Feb 18 '13 at 15:04

0

try to use SharedPreferences, Set it after/with the button-click and get it on 2. Activity OnCreate

answered Feb 18 '13 at 15:04

Eveli

498
1
6
27

im using this for the same issue in my app, but if you think so: show a better way – Eveli Feb 18 '13 at 15:07

score 0 · Answer 4 · answered Feb 18 '13 at 15:07

If you just want to pass a simple String, you can use the following:

On sending:

    Intent i = new Intent(SelectCharacterActivity.this, LevelOneActivity.class);
    i.putExtra("key", selection);
    startActivity(i);

On receiving:

    String selection = getIntent().getStringExtra("key");

If there is no parameter with this key, selectionwill be null.

score 0 · Answer 5 · answered Feb 18 '13 at 15:07

Try this

Intent i = new Intent(FirstActivity.this, SecondActivity.class); i.putExtra("email", "lol@hotmail.com"); startActivity(i);

and

Intent i = getIntent(); String myemail = i.getStringExtra("email");

Furthermore, to compare String, use .equals() not ==

Passing a String value across Activities?

5 Answers5