weights inside a scrollview

Question

In my App i am trying to create a scroll view that has 3 big buttons that fills the entire screen. so every button's size is 1/3 of the screen. How can I do that? When I am using weights its not working .

<ScrollView
    android:id="@+id/scrollView1"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_above="@+id/imageView2"
    android:layout_alignParentLeft="true"
    android:layout_alignParentRight="true"
    android:layout_below="@+id/header_layout" >

    <TableLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:gravity="center_horizontal" >

        <TableRow
            android:id="@+id/tableRow1"
            android:layout_width="wrap_content"
            android:layout_height="0dp"
            android:layout_weight="1"
            android:gravity="center_horizontal" >

            <ImageView
                android:id="@+id/imageView3"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:src="@drawable/main_btn_call" />
        </TableRow>

        <TableRow
            android:id="@+id/tableRow2"
            android:layout_width="wrap_content"
            android:layout_height="0dp"
            android:layout_weight="1"
            android:gravity="center_horizontal" >

            <ImageView
                android:id="@+id/imageView4"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:src="@drawable/main_btn_unlock" />

        </TableRow>

        <TableRow
            android:id="@+id/tableRow3"
            android:layout_width="wrap_content"
            android:layout_height="0dp"
            android:layout_weight="1"
            android:gravity="center_horizontal" >

            <ImageView
                android:id="@+id/imageView5"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:src="@drawable/main_btn_push" />

        </TableRow>
    </TableLayout>

</ScrollView>

What are the exact size of the images which you are using as Buttons? — Harpreet, Feb 21 '13 at 06:07
Please define "they don't work". Don't forget that you need to provide a [mre] for your question to be on-topic. — double-beep, May 24 '19 at 08:18

score 4 · Answer 1 · edited Jan 19 '17 at 19:04

4

The only change is add the following property in your XML:

android:fillViewport="true"

and your scroll view width and height should be match_parent

android:layout_width="match_parent"
android:layout_height="match_parent"

edited Jan 19 '17 at 19:04

Piyush

1,528
2
24
39

answered May 22 '14 at 06:07

Harshad07

608
7
23

score 1 · Answer 2 · answered Feb 20 '13 at 10:32

1

You're using TableLayout which is a LinearLayout with orientation set to vertical - This is all fine so far, you using weights on the layout_height attribute.

The problem as I see it is that you're using wrap_content in both your ScrollView and in your TableLayout. Weight values allow your views to expand to fill space available to it but your parent is wrapping the content to 0 + 0 + 0. If you change the hight to match_parent for both parent elements your weight values will have space to expand

answered Feb 20 '13 at 10:32

Graeme

25,714
24
124
186

this is not working for me.. – roiberg Feb 20 '13 at 10:45
in what way isn't it working? – Graeme Feb 20 '13 at 11:01
It didn't change anything. – roiberg Feb 20 '13 at 12:21
You haven't described in your question what the original problem was (what is displaying and what way is this "not working"). – Graeme Feb 20 '13 at 13:59
the problem is that the images are not sizing them self by the weights, they act like there are no weights in there. the just stack one on the other and not to fill the screen. – roiberg Feb 21 '13 at 15:34
Can you add a screenshot to your question? – Graeme Feb 21 '13 at 15:48

score 1 · Answer 3 · answered Feb 20 '13 at 10:52

I meneged to do this with code:

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    final ImageView incallImage = (ImageView) findViewById(R.id.incall_image);
    final ImageView unlockImage = (ImageView) findViewById(R.id.unlock_image);
    final ImageView pushImage = (ImageView) findViewById(R.id.push_image);
    final ScrollView scrollViewMain = (ScrollView) findViewById(R.id.scroll_view_main);
    scrollViewMain.post(new Runnable() {
        @Override
        public void run() {
            scrollMainHeight = scrollViewMain.getHeight();
            LinearLayout.LayoutParams layoutParams  = new    
                     LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT, scrollMainHeight / 3);
            incallImage.setLayoutParams(layoutParams);
            unlockImage.setLayoutParams(layoutParams);
            pushImage.setLayoutParams(layoutParams);
        }
    });
}

If anyone finds a way to do this in the xml it will be great!, Thanks!

weights inside a scrollview

3 Answers3

Linked